Remove on_new_version_available from Sanity Checker#253
Merged
Conversation
marcoroth
force-pushed
the
remove-on-new-version-available
branch
from
fd23214 to
edf4bc8
Compare
'NOTICE: The `config.on_new_version_available` option has been removed from the CableReady initializer. You can safetly remove this option from your initializer.'
marcoroth
force-pushed
the
remove-on-new-version-available
branch
from
6950cee to
8eb96dc
Compare
2 tasks
marcoroth
added a commit
to stimulusreflex/stimulus_reflex
that referenced
this pull request
Feb 18, 2023
# Type of PR Enhancement ## Description This pull requests removes the `on_new_version_available` option from the StimulusReflex sanity checker and config. In my opinion is has been overly upfront and isn't really needed. If people are stuck with old versions they don't need to constantly be reminded. Similar to stimulusreflex/cable_ready#253 ## Why should this be added So we can simplify things in the code. There is also no need for remote calls to GitHub on every startup of the app/console.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of PR
Enhancement
Description
This pull requests removes the
on_new_version_availableoption from the CableReady sanity checker. In my opinion is has been overly aggressive and isn't really needed. If people are stuck with old versions they don't need to constantly be reminded.Why should this be added
So we can simplify things in the code. There is also no need for remote calls to GitHub on every startup of the app/console.
Checklist