Rename enable_updates to enable_cable_ready_updates#250
Merged
Conversation
Also rename `skip_updates` to `skip_cable_ready_updates`
2 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of PR
Enforcement of Consistency
Description
This pull request renames the two class methods and relation options related to the
CableReady::Updatablemodule:enable_updatestoenable_cable_ready_updatesenable_updatestoenable_cable_ready_updatesskip_updatestoskip_cable_ready_updatesWhy should this be added
The class methods were super generic and didn't indicate that they were originating from CableReady. The method names were also more likely to clash with other upcoming gems which would port this behavior to a Turbo-related project.
Migration
All of the deprecated methods and the options emit a warning if they are used so people know how to migrate them.
enable_updatesrelation optionenable_updatesclass methodskip_updatesclass methodChecklist