Merged
Conversation
hopsoft
approved these changes
Feb 10, 2023
Contributor
hopsoft
left a comment
hopsoft
left a comment
There was a problem hiding this comment.
This is very much needed to help folks debug updatable. One question for you.
| }, | ||
| set (value) { | ||
| debugging = !!value | ||
| }, |
Contributor
There was a problem hiding this comment.
value and set seem to be redundant to the enabled, disabled getters and the debug setter. Do we actually need those functions?
Contributor
Author
There was a problem hiding this comment.
TBH, I just copied this over 1:1 from SR, didn't wanna waste too much time 🙃
but I'll be happy to remove it if you like
| Log.cancel(this.lastUpdateTimestamp, 'Update already requested') | ||
|
|
||
| return | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhancement
Description
Ports over some client side logging functionality from StimulusReflex to better be able to debug and benchmark
Updatableinteractions.As in StimulusReflex, logging has to be explicitly enabled by passing
{debug: true}toCableReady.initialize.Fixes #246
Checklist