Merged
Conversation
The `cable-ready` element was extracted to https://github.com/cableready/element
marcoroth
force-pushed
the
revert-cable-ready-element
branch
from
f20ee78 to
4bc4773
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of PR
Removal
Description
The
<cable-ready>element was extracted to https://github.com/cableready/element so that people which are currently relying on it can still use it. While it works perfectly fine, it's discouraged to use it for new use-cases.Reverts #139
Why should this be removed
The
<cable-ready>element is conceptionally very similar to Turbo Streams. To not confuse people more which technology to choose we are going to remove it from the core part of CableReady.With the recent additions of Custom Turbo Stream Actions in 7.2 Turbo got a lot more powerful. In addition to that there are emerging projects like
turbo_powerwhich bring the same level of power to Turbo Streams as CableReady does.There are still some reasons to choose CableReady over Turbo Streams, but the
<cable-ready>element isn't one of them. CableReady's strength is that it's exactly not a custom element. If you were planning to use<cable-ready>you should use Turbo Streams instead. For the sake of "backwards compability" (technically it was never official released) we are going to extract the<cable-ready>element to a separate repo.Checklist