Fix bug where using an array when calling (add/remove)_css_class didn…#232
Merged
leastbad merged 2 commits intostimulusreflex:masterfrom Dec 28, 2022
Conversation
leastbad
approved these changes
Dec 28, 2022
Contributor
leastbad
left a comment
leastbad
left a comment
There was a problem hiding this comment.
Great work on this.
I added a quick check to remove the class attribute if there are no classes defined.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of PR (feature, enhancement, bug fix, etc.)
This is a bugfix for #231 , while the original issue only mentions
add_css_classwhile working on this, I realized that the same bug affectedremove_css_classand so fixed that too.Description
Please include a summary of the change and which issue is fixed.
Fixes #231
Why should this be added
It fixes a bug.
Checklist
Please note that the best way to suggest changes or updates to the documentation is to join Discord and leave a note in the #docs channel. Any documentation updates posted as PRs cannot be accepted at this time. ❤️