Explicit check for leaf parent element presence for updates_for#208
Merged
leastbad merged 1 commit intostimulusreflex:masterfrom Jun 1, 2022
Merged
Conversation
Contributor
|
Would you mind running |
rickbenavidez
force-pushed
the
fix-leaf-updates
branch
from
e893099 to
ede58e2
Compare
rickbenavidez
force-pushed
the
fix-leaf-updates
branch
from
ede58e2 to
abf7d2a
Compare
Contributor
Author
|
Thanks for the review @leastbad! Command run, commit amended. |
marcoroth
approved these changes
Jun 1, 2022
Member
marcoroth
left a comment
marcoroth
left a comment
There was a problem hiding this comment.
Thanks @rickbenavidez! This looks good from my side! 👍🏼
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In certain scenarios, the call to recursive updates associated with updates_for may fail if the leaf's parent Element is null.
This results in an error similar to the following:
Uncaught TypeError: e2.parentElement is nullTo prevent the error we'll perform an explicit check on the presence of the parent element before attempting to call closest().