Ship prebuilt JavaScript with the cable_ready gem#191
Merged
Conversation
marcoroth
force-pushed
the
ship-prebuilt-js-with-gem
branch
from
45daf95 to
9c59654
Compare
julianrubisch
approved these changes
Mar 17, 2022
Contributor
julianrubisch
left a comment
julianrubisch
left a comment
There was a problem hiding this comment.
I'm very excited for this!
marcoroth
force-pushed
the
ship-prebuilt-js-with-gem
branch
from
1ed7699 to
2bc4e9d
Compare
3 tasks
marcoroth
force-pushed
the
ship-prebuilt-js-with-gem
branch
from
1694f1c to
3351dc9
Compare
Contributor
|
I am highly appreciative of all of the work happening in this PR. |
This was referenced Apr 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of PR
Feature
Description
This enables Rails Applications to easily include the CableReady JavaScript client into their app by just installing the
cable_readyRubygem.Either with Import maps:
Or with the regular Asset pipeline:
Why should this be added
To get your Non-webpack/non-esbuild powered Rails 7 Application up and running with CableReady by just installing the Rubygem.
Checklist