Fix text_content operation for nullish values#176
Merged
Conversation
KonnorRogers
reviewed
Jan 6, 2022
Co-authored-by: Konnor Rogers <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of PR
Bug Fix
Description
This PR adds a check to make sure that we use the provided
textparameter if it's not nullishWhy should this be added
The
text_contentoperation always used an empty string for thetextparameter if the value of thetextparameter was nullish.Previously if you passed in
0as a value fortextit would have still used the empty string instead.Checklist