Updated gemspec to specific Rails gems#175
Conversation
Most apps don't require the full suite of Rails gems, and can avoid installing them to save CI and deploy time. This gem, however, had a dependency on the Rails meta-gem which ended up installing them all anyways. Instead, we can limit it to only the Rails gems that we directly depend upon.
paul
force-pushed
the
restrict-dependencies
branch
from
d1ea0e6 to
ab0457e
Compare
|
I added The bigger question which @julianrubisch is better-equipped to answer is whether the test dummy requiring all of Rails means that the Gemspec for CableReady needs to include all of Rails. |
|
nvm: took care of it! |
Well the easiest way to tell is to, well, run the tests. But either way I think it could be added as a development dependency... |
LGTM: |
3 participants
Most apps don't require the full suite of Rails gems, and can avoid installing them to save CI and deploy time. This gem, however, had a dependency on the Rails meta-gem which ended up installing them all anyways.
Instead, we can limit it to only the Rails gems that we directly depend upon.
I'm not sure how to really test this, since the dummy app uses all of Rails. I grep'd through
./libto see what parts of Rails were being used, but that might not be comprehensive.Note: I ran
./bin/standardizeas instructed by the README, but it touched dozens of files which I didn't commit as part of this PR.