Query all eager loading turbo frames and patch their innerHTML#164
Merged
leastbad merged 4 commits intostimulusreflex:masterfrom Nov 22, 2021
Merged
Query all eager loading turbo frames and patch their innerHTML#164leastbad merged 4 commits intostimulusreflex:masterfrom
leastbad merged 4 commits intostimulusreflex:masterfrom
Conversation
leastbad
reviewed
Nov 20, 2021
Contributor
leastbad
left a comment
leastbad
left a comment
There was a problem hiding this comment.
So far as I understand the functionality of lazy-loaded Turbo Frames, this looks sound to me. I guess they use DOM ids to identify frames? For some reason, I thought they gave them arbitrary identifiers.
Depending on your reaction to one of my questions, you might need to make the lazy fetch into a recursive function.
julianrubisch
changed the title
Contributor
Author
|
Yep, frames all use IDs right now. |
julianrubisch
force-pushed
the
ssr-turbo-frames
branch
2 times, most recently
from
8685c71 to
6ffc111
Compare
julianrubisch
force-pushed
the
ssr-turbo-frames
branch
from
6ffc111 to
22ea8f6
Compare
julianrubisch
force-pushed
the
ssr-turbo-frames
branch
from
22ea8f6 to
fcbb462
Compare
Contributor
|
Excited to see this coming together. |
Contributor
Author
|
So I can declare success! I threw together a couple of test cases including nested eager loaded frames, and it worked. Thanks to @ParamagicDev for your support and reviewing it en passent 🙌 |
leastbad
approved these changes
Nov 22, 2021
Contributor
leastbad
left a comment
leastbad
left a comment
There was a problem hiding this comment.
LGTM with comments re: naming and a request for clarification.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows to fetch and patch lazy loaded turbo frames present in the response eagerly.