updates_for :only option#163
Merged
leastbad merged 7 commits intostimulusreflex:masterfrom Nov 12, 2021
Merged
Conversation
julianrubisch
requested changes
Nov 12, 2021
app/models/concerns/cable_ready/updatable/model_updatable_callbacks.rb
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #161
While I believe that a Model has no business knowing anything about views, @andrewerlanger's desire to eliminate unnecessary HTTP requests is highly reasonable. Therefore, instead of attempting to further complicate the
enable_updatesmethod with the potential for multiple calls that each target different views, this PR gives theupdates_forhelper the ability to optionally filter out messages which don't contain the right keys.Any broadcasts which update individual model instances now transmit an array of attribute names that were updated:
The
onlyoption currently accepts only a simple string that exactly matches the name of an attribute. There's no checking to ensure that it is a valid attribute, and there's no support forand/or-ing multiple attributes. I don't think that we need this feature to be Turing complete to be Just The Right Amount of functionality.Note that this feature has no impact on Model messages (create/destroy) because it only works on
after_updatecallbacks for individual model instances.