error handling for updates_for edge cases#155
Merged
julianrubisch merged 2 commits intostimulusreflex:masterfrom Oct 6, 2021
Merged
error handling for updates_for edge cases#155julianrubisch merged 2 commits intostimulusreflex:masterfrom
julianrubisch merged 2 commits intostimulusreflex:masterfrom
Conversation
leastbad
added
enhancement
proposal
javascript
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two additions:
Component will now report that a url cannot be fetched, and abort with an error log with the failed url.
If there is a mismatch between the number of
updates_forelements on the origin page and theurlspecified (or if the current page changes between updates!) this is handled as follows:Originally, I was going to make it notify the developer that there were mroe data points than could be displayed; however, given the complexity of supporting multiple URLs, which could all have different amounts of numbers, I decided to take a pass on trying to create logic for the "too many" case.