Fix wrong CableReady import#146
Merged
marcoroth merged 1 commit intostimulusreflex:masterfrom Sep 7, 2021
n-rodriguez:fix_import
Merged
Fix wrong CableReady import#146marcoroth merged 1 commit intostimulusreflex:masterfrom n-rodriguez:fix_import
marcoroth merged 1 commit intostimulusreflex:masterfrom
n-rodriguez:fix_import
Conversation
marcoroth
reviewed
Sep 3, 2021
Member
There was a problem hiding this comment.
Hey @n-rodriguez
Thank you for this pull request!
I think it would even make more sense if we just import the perform function from the cable_ready.js file and update L15 to:
if (data.cableReady) perform(data.operations)What do you think?
Fix this error: ERROR in ./.yarn/cache/cable_ready-npm-5.0.0-pre3-b6a471a50a-bf6c2acdbd.zip/node_modules/cable_ready/javascript/stream_from_element.js 15:33-51 export 'default' (imported as 'CableReady') was not found in 'cable_ready' (possible exports: initialize, perform, performAsync)
Contributor
Author
|
@marcoroth good catch! it's fixed. |
marcoroth
approved these changes
Sep 7, 2021
Member
|
Thank you @n-rodriguez! |
Contributor
|
Great work on this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix this error: