Introduce OperationStore to add operations on-the-fly#124
Merged
leastbad merged 4 commits intostimulusreflex:masterfrom May 13, 2021
Merged
Introduce OperationStore to add operations on-the-fly#124leastbad merged 4 commits intostimulusreflex:masterfrom
OperationStore to add operations on-the-fly#124leastbad merged 4 commits intostimulusreflex:masterfrom
Conversation
This also removes the `playSound` operation. The operation has been extracted to: https://github.com/cableready/audio_operations
leastbad
approved these changes
May 12, 2021
Contributor
leastbad
left a comment
There was a problem hiding this comment.
This is a masterclass-level refactoring job. Bravo.
Contributor
|
Would it make sense to implement |
Contributor
I'm ok to punt on this unless y'all feel we should do it now vs later. |
and when it's not our `stream-from` element
3 tasks
This was referenced Jan 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of PR
Feature
Description
This PR introduces a
OperationStoreto add operations on-the-fly.This also removes the
playSoundoperation. The operation has been extracted to: https://github.com/cableready/audio_operationsWith that a developer can add custom operations from packages to their app.
Deprecate
CableReady.DOMOperationsAs CableReady is more than just "DOM operations" we should also change the name. This is still supported but shows a deprecation warning:
Instead you can now use this:
As a side effect it now also allows more ways of defining custom operations:
Why should this be added
Developers can build npm packages with pre-build CableReady operations and just add them with a simple function call to CableReady.
Checklist