Merged
Conversation
hopsoft
approved these changes
Apr 7, 2021
Contributor
hopsoft
left a comment
There was a problem hiding this comment.
Looks great and will support some interesting use cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
set_metaupdates thecontentof ametatag in the document head.If no tag is found, it is created.
Example
Here's a Nothing Reflex that updates a meta tag:
Motivation
I've found a really interesting pattern for building UI functionality that makes extensive use of
metatags.This is all tied together with a Stimulus controller that observes
metatags:Basically, any menu items which can feature a notification "pill" observe a
metatag for changes, and update themselves when the meta tag is updated. If there is nocontentor the content is0, the pill is hidden.This is very similar to using
set_dataset_propertywith the Values API, except that it has two advantages:metatag, and they don't have to be aware of each other