Conversation
hopsoft
requested changes
Feb 15, 2021
Contributor
hopsoft
left a comment
hopsoft
left a comment
There was a problem hiding this comment.
Looks like cleanup for ended is incorrect. Shouldn't it be?
document.audio.removeEventListener('ended', ended)
Contributor
Author
|
Nice catch. |
hopsoft
approved these changes
Feb 15, 2021
nhocki
added a commit
to nhocki/cable_ready
that referenced
this pull request
Apr 16, 2021
Audio was made opt-in in stimulusreflex#112 but this breaks the current default by disabling audio. This commit changes it back to the current default (on) but allows people to turn it off by adding the `data-lock-audio` attribute.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems as though I was over-zealous in my enthusiasm for the
play_soundoperation; the bootstrap code interferes with strict CSPs and hijacks the audio context on a Mac.This PR introduces a requirement that developers who wish to use the
play_soundoperation must place adata-unlock-audioattribute on theirbodytag. Otherwise, the operation will be a NOOP.Fixes #111