Merged
Conversation
Contributor
Author
|
Just a reminder to myself that once this PR (hopefully!) goes in, that the follow-up is in the before_after branch. |
hopsoft
approved these changes
Feb 9, 2021
Contributor
hopsoft
left a comment
hopsoft
left a comment
There was a problem hiding this comment.
👍🏻 This is great. I've been hoping to get a similar refactor in myself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR primaryily exists to move the giant
DOMOperationsobject out of the maincable_ready.jsfile.It also converts
activeElementto a memoized object with anelementgetter and asetsetter.didMorphandshouldMorphhave been moved into the [renamed]morph_callbacks.js, although theshouldMorphCallbacksanddidMorphCallbacksarrays are still defined in the main file, as they are part of the public API.This PR doesn't add or remove any functionality. It has been tested successfully against my CR tests harness.