Merged
Conversation
Adds `ttl` and `max_entries` params to `@st.cache` - Each `@st.cache`d function now has its own in-memory cache (previously, all functions shared a single cache). - `cachetools.LRUCache` and `cachetools.TTLCache` replace raw dictionaries as the cache implementations. This closes #364. (Well, partly: per discussions with @tvst and @treuille, the other bits of that ticket (`global` and `finalizer_func` options) are going to wait for more discussion about caching changes.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
ttlandmax_entriesparams to@st.cache@st.cached function now has its own in-memory cache (previously, all functions shared a single cache).cachetools.LRUCacheandcachetools.TTLCachereplace raw dictionaries as the cache implementations.This closes #364. (Well, partly: per discussions with @tvst and @treuille, the other bits of that ticket (
globalandfinalizer_funcoptions) are going to wait for more discussion about caching changes.)Before contributing (PLEASE READ!)
This helps make sure (1) two people aren't working on the same thing, (2) this is something Streamlit's maintainers believe should be implemented/fixed, (3) any API, UI, or deeper architectural changes that need to be implemented have been fully thought through by Streamlit's maintainers.
More information in our wiki: https://github.com/streamlit/streamlit/wiki/Contributing
Issue: Please include a link to the issue you're addressing. If no issue exists, create one first and then link it here.
Description: Describe the changes you made to the code, so it's easier for the reader to navigate your pull request. Usually this is a bullet list.
Contribution License Agreement
By submiting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.