Fix CI failures: gofmt, gosec G204, and unparam warnings#1790
Merged
steveyegge merged 1 commit intosteveyegge:mainfrom Feb 16, 2026
Merged
Fix CI failures: gofmt, gosec G204, and unparam warnings#1790steveyegge merged 1 commit intosteveyegge:mainfrom
steveyegge merged 1 commit intosteveyegge:mainfrom
Conversation
Add cmd/bd/stubs.go to the G204 exclusion list since its exec.Command args come from internal logic, not user input. Remove the unused error return from performContentMerge — it always returns nil since errors from extractJSONLFromCommit are intentionally swallowed (falls back to empty content). Co-Authored-By: Claude Opus 4.6 <[email protected]>
sjsyrek
force-pushed
the
fix/ci-lint-failures
branch
from
ab9edf3 to
bb3fef9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI on
mainis failing with formatting violations, a gosec G204 warning, and an unparam warning. This PR fixes all three to unblock PRs.Changes Made
gofmton all files — fixes trailing whitespace, extra blank lines, and comment alignment across 24 filescmd/bd/stubs.goto G204 exclusion in.golangci.yml— theexec.Commandargs come from internal logic, not user input, matching the existing pattern for 12+ other fileserrorreturn fromperformContentMerge()— the function always returnednilsince errors fromextractJSONLFromCommitare intentionally swallowed (falls back to empty content). Updated 2 call sites and 2 test call sites.Backward Compatibility
✅ Maintained: No behavioral changes — formatting only + removing dead error path
✅ Same behavior:
performContentMergealready never returned an errorSize: Small ✓
Mechanical formatting + two targeted lint fixes.
🤖 Generated with Claude Code