Suggestions#12
Merged
steverao merged 2 commits intosteverao:convert-lettuce-to-use-instrumenterfrom Feb 15, 2026
Merged
Conversation
DbClientAttributesGetter extends ServerAttributesGetter, so DbClientAttributesExtractor already handles server attributes internally. Remove the separate LettuceServerAttributesGetter and ServerAttributesExtractor to match the canonical pattern used by other DB instrumentations (Jedis, etc.).
Null out context after instrumenter.end() to guard against both the onComplete callback and Lettuce's direct finish() call executing. Add comment explaining error lifecycle when start() was not called.
steverao
approved these changes
Feb 15, 2026
| public synchronized void finish() { | ||
| if (context != null) { | ||
| instrumenter.end(context, request, response, error); | ||
| // Null out context to prevent double-ending if both the onComplete callback and Lettuce's |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.