Rework spymemcached server attribute handling#11
Merged
steverao merged 1 commit intosteverao:spymemcachedfrom Feb 17, 2026
Merged
Rework spymemcached server attribute handling#11steverao merged 1 commit intosteverao:spymemcachedfrom
steverao merged 1 commit intosteverao:spymemcachedfrom
Conversation
laurit
commented
Feb 13, 2026
| return callDepth; | ||
| public static AdviceScope<OperationFuture<?>, OperationCompletionListener> methodEnter( | ||
| @Advice.This MemcachedClient client, @Advice.Origin("#m") String methodName) { | ||
| return AdviceScope.start(AsyncOperationHandler.INSTANCE, client, methodName); |
Author
There was a problem hiding this comment.
start span at the start of the method as we do in other instrumetnations
laurit
commented
Feb 13, 2026
| : null), | ||
| equalTo(maybeStable(DB_SYSTEM), MEMCACHED), | ||
| equalTo(maybeStable(DB_OPERATION), "decr"), | ||
| equalTo(SERVER_ADDRESS, memcachedContainer.getHost()), |
Author
There was a problem hiding this comment.
Since the exception is thrown before the request is sent to the server we can't fill the server attributes (unless theres is only 1 node). Without this PR the exception tests fail when they are run without other tests so the address probably leaked over from a previous test.
steverao
approved these changes
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.