Docker add build matrix #3
Conversation
|
3.9 is better as there are something, like cebra, that don't work in 3.8 and we want to try to keep interoperability :D |
ok, no pb, I can rebuild for dockerhub, I guess we were discussing different dependencies preferences, but not the python one haha |
|
@stes LGTY? |
|
@MMathisLab we discussed with @jeylau to delete python3-dev and protobuff from Dockerfile: I need to rebuild and test again, but there is this "mirror bug" still, so need to wait (Monday?) |
|
@maryapp to "try" removing python3-dev to see if that explains python3.8 and python3.9 living together in the container 😅 |
This comment was marked as outdated.
This comment was marked as outdated.
|
Why can't we update TF? Looking at https://www.tensorflow.org/install/source#gpu, it looks like we could install TF up to 2.11 w/ CUDA 11.2 and python >3.7,<3.10. |
|
yes, we should only be using TF 2.10 -- that is the developer agreed final version of TF we will support. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
@jeylau check it please, now it should be fine! |
|
|
|
@stes let's merge, please! |
stes
left a comment
stes
left a comment
There was a problem hiding this comment.
minor comments.
I assume this is tested for GUI and console?
Co-authored-by: Steffen Schneider <[email protected]>
Co-authored-by: Steffen Schneider <[email protected]>
stes
left a comment
stes
left a comment
There was a problem hiding this comment.
Assuming that all tests pass, this looks good to me!
4 participants
Here is the updates to merge the main PR after this one.
Re: @MMathisLab
Main minor changes:
Last - new images on dockerhub are functional and built from this version of code!
PS sorry for "shift reds" in build.sh, probably we are using different style-formatter + I added some minor docs-lines