Add Toothpick.hasScope method for check scope in scopes tree.#318
Merged
dlemures merged 6 commits intostephanenicolas:masterfrom Feb 4, 2019
Merged
Conversation
This was referenced Jan 14, 2019
|
Nice! I've been waiting for this feature for a long time |
dimsuz
reviewed
Jan 14, 2019
rovkinmax
approved these changes
Jan 14, 2019
dimsuz
reviewed
Jan 14, 2019
Contributor
Author
|
@stephanenicolas @dlemures what do you think about it? |
Contributor
Author
|
@stephanenicolas done 👌 |
| //GIVEN | ||
|
|
||
| //WHEN | ||
| Boolean isFooScopeOpen = Toothpick.isScopeOpen("foo"); |
Owner
There was a problem hiding this comment.
please use a small b boolean.
Contributor
Author
There was a problem hiding this comment.
Oops :) It's Kotlins habit
Owner
|
We will be glad to merge and release after the comments are addressed. Thx @terrakok |
Collaborator
|
Looks great :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example of usage:
We can use it method for first initialization UI scope after Activity restore on Android OS.
At the moment we should to do like this:
BaseFragment.kt
😭😭😭