[hostcfgd] differentiate between UnitFileState and UnitFilePreset#43
Closed
stepanblyschak wants to merge 2 commits intomasterfrom
Closed
[hostcfgd] differentiate between UnitFileState and UnitFilePreset#43stepanblyschak wants to merge 2 commits intomasterfrom
stepanblyschak wants to merge 2 commits intomasterfrom
Conversation
It can be that service is not enabled but UnitFilePreset=enabled (case
for Application Extension):
```
Loaded: loaded (/lib/systemd/system/cpu-report.service; disabled; vendor preset: enabled)
```
This makes existing logic skip enabling the service.
Signed-off-by: Stepan Blyschak <[email protected]>
Signed-off-by: Stepan Blyschak <[email protected]>
stepanblyschak
pushed a commit
that referenced
this pull request
Jan 24, 2022
457e94d51 [macsec_linux]: Fixbug cannot dump the PN due to type error (#42) f7c073323 Disable P2P module (#41) 7b3b777e2 [ci]: use native arm64 and armhf build pool (#40) d4e91d66c [sonic_operator]: Increase wait timeout (#39) 43611ef88e [sonic_operators]: Add log in sonic operators (#43) Signed-off-by: Ze Gan <[email protected]>
stepanblyschak
pushed a commit
that referenced
this pull request
Apr 3, 2022
…onic-net#10406) #### Why I did it To take the following into sonic-buildimage 36e1f61 API endpoints to ConfigDBConnector to support pre-loading data without blackout (sonic-net#587) [sonic-swss-common](https://github.com/Azure/sonic-swss-common) ``` 36e1f61 API endpoints to ConfigDBConnector to support pre-loading data without blackout (sonic-net#587) 556f4ad Add SAI copy action to ACL schema (sonic-net#591) db18c3a Fix bitwidth of mac address in SAI ACL schema (sonic-net#590) e9442bb [ConfigDBPipeConnector]: Added set_entry API (sonic-net#586) 6c007c0 Update README for gmock (sonic-net#562) ``` [sonic-linkmgrd](https://github.com/Azure/sonic-linkmgrd) ``` 83dfc99 Enforce uniform file/class naming convention (#52) 83004bf Shutdown ICMP heartbeats when default route state is missing and ToR is in `auto` mode (#44) b81ea31 Add `LinkProberStateMachineActiveActive` (#47) c43cf7a Decrease link probing interval after switchover to better determine the overhead of a toggle (#43) 2239fbe Enhance clang format (#46) ``` #### How I did it * Advanced submodules pointers #### How to verify it 1. make configure PLATFORM=mellanox 2. make target/sonic-mellanox.bin
stepanblyschak
pushed a commit
that referenced
this pull request
Apr 18, 2022
[202012][sonic-linkmgrd]Submodule update 8507629 Jing Zhang Mon Apr 4 10:25:22 2022 -0700 Lower unsolicited MUX state change notification log level to WARNING #57 17d217d Longxiang Lyu Mon Mar 21 12:15:19 2022 +0800 Enhance clang format (#46) c72fa2a Jing Zhang Fri Apr 1 12:23:29 2022 -0700 Disable the feature that decreases link probe interval for measuring switch overhead #49 (#54) 256b01b Jing Zhang Thu Mar 31 16:20:00 2022 -0700 Update link prober metrics posting logics #50 #53 dfd48d0 Jing Zhang Wed Mar 23 16:27:45 2022 -0700 Decrease link probing interval after switchover to better determine the overhead of a toggle #43 (#48) sign-off: Jing Zhang [email protected]
stepanblyschak
pushed a commit
that referenced
this pull request
Sep 25, 2023
…ly (sonic-net#16566) #### Why I did it src/dhcprelay ``` * 2b33d76 - (HEAD -> master, origin/master, origin/HEAD) dhcpv6 per interface counter support (#43) (7 days ago) [jcaiMR] ``` #### How I did it #### How to verify it #### Description for the changelog
stepanblyschak
pushed a commit
that referenced
this pull request
Feb 24, 2025
…ly (sonic-net#21743) #### Why I did it src/sonic-stp ``` * 29eb387 - (HEAD -> master, origin/master, origin/HEAD) Fixing compilaion error for marvell_armhf (#47) (9 hours ago) [Divya Kumaran Chandralekha] * b7da558 - Merge pull request #44 from wajahatrazi/stp_co_pr (3 days ago) [Divya Kumaran Chandralekha] |\ | failure_prs.log skip_prs.log 47e1e77 - Merge branch 'master' into stp_co_pr (3 days ago) [Divya Kumaran Chandralekha] | |\ | |/ |/| * | 6e4a94f - Merge pull request #46 from divyachandralekha/pvst_pr_1 (4 days ago) [Divya Kumaran Chandralekha] |\ \ | failure_prs.log skip_prs.log | aa5e824 - libevent explicit building dependency removed (4 days ago) [Divya Chandralekha] |/ / * | 9345e5a - Merge pull request #43 from omaaartamer/fix/alignment-warnings (5 days ago) [Divya Kumaran Chandralekha] * | eedb772 - [stp] Add memory alignment padding to structures (9 weeks ago) [omaaartamer] * | 128e53d - fix: resolve STP alignment warnings (9 weeks ago) [omaaartamer] / * 30febfa - Fixing changes in the code (9 weeks ago) [Wajahat Razi] ``` #### How I did it #### How to verify it #### Description for the changelog
stepanblyschak
pushed a commit
that referenced
this pull request
May 20, 2025
… automatically (sonic-net#745) #### Why I did it src/sonic-platform-common ``` * 64407ff - (HEAD -> 202412, origin/202412) [code sync] Merge code from sonic-net/sonic-platform-common:202411 to 202412 (#43) (14 seconds ago) [mssonicbld] ``` #### How I did it #### How to verify it #### Description for the changelog
stepanblyschak
pushed a commit
that referenced
this pull request
May 20, 2025
…D automatically (sonic-net#1007) #### Why I did it src/sonic-sairedis ``` * e6fc812 - (HEAD -> 202412, origin/HEAD, origin/202412) Merge sonic-net/sonic-sairedis 202411 to 202412 (#44) (4 minutes ago) [Riff] * 75ecb0f - [vslib] SAI_KEY_VS_OPER_SPEED_IS_CONFIGURED_SPEED, SAI_PORT_ATTR_HOST_TX_READY_STATUS support (#43) (52 minutes ago) [mssonicbld] ``` #### How I did it #### How to verify it #### Description for the changelog
stepanblyschak
pushed a commit
that referenced
this pull request
May 20, 2025
… HEAD automatically (sonic-net#1017) #### Why I did it src/sonic-linux-kernel ``` * 274843c - (HEAD -> 202412, origin/HEAD, origin/202412) Merge pull request #43 from r12f/code-sync-202412 (32 minutes ago) [Riff] * b865879 - Merge remote-tracking branch 'base/202411' into code-sync-202412 (13 hours ago) [r12f] * a89afbc - [202411] Update to Linux 6.1.123 (sonic-net#459) (8 days ago) [Saikrishna Arcot] ``` #### How I did it #### How to verify it #### Description for the changelog
stepanblyschak
pushed a commit
that referenced
this pull request
Jul 22, 2025
…sonic-net#22940) #### Why I did it src/dhcpmon ``` * cf192dd - (HEAD -> master, origin/master, origin/HEAD) Fix incorrect counting in for packets related to standby interface in dualtor (#43) (4 days ago) [Yaqiang Zhu] ``` #### How I did it #### How to verify it #### Description for the changelog
stepanblyschak
pushed a commit
that referenced
this pull request
Aug 6, 2025
…tically (sonic-net#23388) #### Why I did it src/sonic-dash-api ``` * 78a3884 - (HEAD -> master, origin/master, origin/HEAD) Undeprecate action_type, change field type to ActionType (#43) (10 hours ago) [Lawrence Lee] ``` #### How I did it #### How to verify it #### Description for the changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It can be that service is not enabled but UnitFilePreset=enabled (case
for Application Extension):
This makes existing logic skip enabling the service.
Signed-off-by: Stepan Blyschak [email protected]
Why I did it
To fix an issue when a 3rd party package cannot be started by hostcfgd.
How I did it
Check explicitely for UnitFileState.
How to verify it
Ran UT & ran it on the switch.
Installed 3rd party package and enabled it in config db, verified feature can start.
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)