Install libdbus-1-dev for cli - #109
Conversation
this is a dependency for keyring, which we're using for signing with keychains/secure store
Co-authored-by: Willem Wyndham <[email protected]>
|
does this library need to be on the system path at cli runtime? if so, then need to add the dep to the main image - https://github.com/stellar/system-test/blob/master/Dockerfile#L30 |
@sreuland good call. I'm looking into this, and was able to repro the issue locally using act. I found that adding this dependency to the quickstart image also worked to fix the issue. stellar/quickstart#662 I'm testing out adding it to the system path right now, like you suggested right now. That may be a better place to fix this specific issue. |
|
@sreuland just opened a PR with the fix you suggested: #118 Not 100% sure, but I think that we will likely still also want to include these libraries in the quickstart image as well, so stellar/quickstart#662 is also probably still relevant. Does that make sense to you @leighmcculloch ? |
No, just for confirm on this thread, the cli deps not required in quickstart, per comment on quickstart#662 |
this is a dependency for keyring, which we're using for signing with keychains/secure store
related to stellar/stellar-cli#1481
related cli pr: stellar/stellar-cli#1703