Skip to content
This repository was archived by the owner on Mar 19, 2026. It is now read-only.

Install libdbus-1-dev for cli - #109

Merged
sreuland merged 2 commits into
stellar-deprecated:masterfrom
theahaco:install-libdbus-1-dev-for-cli
Jan 9, 2025
Merged

Install libdbus-1-dev for cli#109
sreuland merged 2 commits into
stellar-deprecated:masterfrom
theahaco:install-libdbus-1-dev-for-cli

Conversation

@elizabethengelman

@elizabethengelman elizabethengelman commented Dec 5, 2024

Copy link
Copy Markdown
Contributor

this is a dependency for keyring, which we're using for signing with keychains/secure store

related to stellar/stellar-cli#1481

related cli pr: stellar/stellar-cli#1703

this is a dependency for keyring, which we're using for signing with
keychains/secure store
Comment thread Dockerfile.soroban-cli Outdated
Co-authored-by: Willem Wyndham <[email protected]>
@sagpatil
sagpatil requested a review from ifropc January 9, 2025 21:18
@sreuland
sreuland merged commit 5df600c into stellar-deprecated:master Jan 9, 2025
@sreuland

Copy link
Copy Markdown
Contributor

does this library need to be on the system path at cli runtime? if so, then need to add the dep to the main image - https://github.com/stellar/system-test/blob/master/Dockerfile#L30

@elizabethengelman

elizabethengelman commented Jan 27, 2025

Copy link
Copy Markdown
Contributor Author

does this library need to be on the system path at cli runtime? if so, then need to add the dep to the main image - https://github.com/stellar/system-test/blob/master/Dockerfile#L30

@sreuland good call. I'm looking into this, and was able to repro the issue locally using act. I found that adding this dependency to the quickstart image also worked to fix the issue. stellar/quickstart#662

I'm testing out adding it to the system path right now, like you suggested right now. That may be a better place to fix this specific issue.

@elizabethengelman

Copy link
Copy Markdown
Contributor Author

@sreuland just opened a PR with the fix you suggested: #118

Not 100% sure, but I think that we will likely still also want to include these libraries in the quickstart image as well, so stellar/quickstart#662 is also probably still relevant. Does that make sense to you @leighmcculloch ?

@sreuland

Copy link
Copy Markdown
Contributor

@sreuland just opened a PR with the fix you suggested: #118

Not 100% sure, but I think that we will likely still also want to include these libraries in the quickstart image as well, so stellar/quickstart#662 is also probably still relevant. Does that make sense to you @leighmcculloch ?

No, just for confirm on this thread, the cli deps not required in quickstart, per comment on quickstart#662

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants