SEP-44, CAP-61: Move memo into fifth event topic - #1541
Merged
Conversation
leighmcculloch
marked this pull request as ready for review
September 4, 2024 10:35
leighmcculloch
enabled auto-merge (squash)
September 4, 2024 10:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Move memo into fifth event topic field in SEP-44 and CAP-61.
Why
The fourth event topic already being used in the built-in token implementation is problematic as it causes existing applications already ingesting transfer events to need to change which topic field they expect the sep11 asset name to be in.
Moving the memo to the fifth topic field is a small change that increases the chance SEP-44 is a forward compatible change.