SEP-41, SEP-44, CAP-61: Add optional token name to token event topics - #1540
Closed
leighmcculloch wants to merge 1 commit into
Closed
SEP-41, SEP-44, CAP-61: Add optional token name to token event topics#1540leighmcculloch wants to merge 1 commit into
leighmcculloch wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
In [SEP-41] add an optional token name to the topic list of all events.
Why
The built-in implementation of the token interface, the Stellar Asset Contract ([CAP-46-6]), already outputs the asset name in the topic list.
In SEP-44 we propose adding a new topic value to transfer events, the memo, but it is difficult to do so with [SEP-41] not specifying a fourth topic when [CAP-46-6] does.
cc @tomerweller