Skip to content

SDP-1801: Add Feature Flag for enabling Anchor Platform - #803

Merged
dpohr merged 9 commits into
sdp-sep-wallet-registrationfrom
SDP-1801-add-ff-for-enabling-AP
Aug 26, 2025
Merged

SDP-1801: Add Feature Flag for enabling Anchor Platform#803
dpohr merged 9 commits into
sdp-sep-wallet-registrationfrom
SDP-1801-add-ff-for-enabling-AP

Conversation

@dpohr

@dpohr dpohr commented Aug 12, 2025

Copy link
Copy Markdown
Contributor

What

Introduce a new feature flag ENABLE_ANCHOR_PLATFORM with default=false

  • ENABLE_ANCHOR_PLATFORM=true SEP-1 TOML file points to anchor platform URLs

  • ENABLE_ANCHOR_PLATFORM=false SEP-1 TOML file points to SDP SEP10/SEP24 URLs.

  • Add deprecation notice to all anchor related configuration in the SDP.

Why

[TODO: Why this change is being made. Include any context required to understand the why.]

Known limitations

[TODO or N/A]

Checklist

  • Title follows SDP-1234: Add new feature or Chore: Refactor package xyz format. The Jira ticket code was included if available.
  • PR has a focused scope and doesn't mix features with refactoring
  • Tests are included (if applicable)
  • CHANGELOG.md is updated (if applicable)
  • CONFIG/SECRETS changes are updated in helmcharts and deployments (if applicable)
  • Preview deployment works as expected
  • Ready for production

@dpohr
dpohr had a problem deploying to Anchor Integration Tests August 12, 2025 13:29 — with GitHub Actions Failure
@dpohr
dpohr temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) August 12, 2025 13:29 — with GitHub Actions Inactive
@dpohr
dpohr changed the base branch from develop to sdp-sep-wallet-registration August 12, 2025 13:29
@dpohr
dpohr temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) August 12, 2025 13:31 — with GitHub Actions Inactive
@dpohr
dpohr had a problem deploying to Anchor Integration Tests August 12, 2025 13:31 — with GitHub Actions Failure
@dpohr
dpohr had a problem deploying to Anchor Integration Tests August 12, 2025 13:40 — with GitHub Actions Failure
@dpohr
dpohr temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) August 12, 2025 13:40 — with GitHub Actions Inactive
@dpohr
dpohr marked this pull request as ready for review August 12, 2025 13:42
@dpohr
dpohr requested a review from marwen-abid August 12, 2025 13:42
@marwen-abid marwen-abid changed the title Sdp 1801 add ff for enabling ap SDP-1801: Add Feature Flag for enabling Anchor Platform Aug 12, 2025
@marwen-abid
marwen-abid requested a review from Copilot August 12, 2025 18:13

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new feature flag ENABLE_ANCHOR_PLATFORM with default value false to control whether the SEP-1 TOML file points to Anchor Platform URLs or SDP native SEP10/SEP24 URLs. The change also adds deprecation notices to existing Anchor Platform configuration parameters.

  • Adds EnableAnchorPlatform boolean field to configure URL routing behavior in SEP-1 TOML files
  • Implements conditional URL logic in the TOML handler based on the feature flag state
  • Adds comprehensive test coverage for both enabled and disabled anchor platform scenarios

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
internal/serve/serve.go Adds EnableAnchorPlatform field and validation logic for anchor platform configuration
internal/serve/httphandler/stellar_toml_handler.go Implements conditional URL generation logic based on feature flag state
internal/serve/httphandler/stellar_toml_handler_test.go Extensive test updates covering both enabled/disabled scenarios with tenant contexts
cmd/serve.go Adds CLI flag for the feature and deprecation notices to existing anchor platform flags
helmchart/sdp/values.yaml Adds configuration parameter with default false value and deprecation notice
helmchart/sdp/README.md Updates documentation with new parameter and deprecation warnings
internal/serve/serve_test.go Updates test configuration to include new fields
cmd/serve_test.go Updates test to include EnableAnchorPlatform field

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread internal/serve/httphandler/stellar_toml_handler.go
Comment thread internal/serve/httphandler/stellar_toml_handler_test.go
Comment thread cmd/serve.go
Comment thread helmchart/sdp/values.yaml Outdated
@dpohr
dpohr had a problem deploying to Anchor Integration Tests August 18, 2025 11:26 — with GitHub Actions Failure
@dpohr
dpohr temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) August 18, 2025 11:26 — with GitHub Actions Inactive
@dpohr
dpohr temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) August 18, 2025 11:29 — with GitHub Actions Inactive
@dpohr
dpohr had a problem deploying to Anchor Integration Tests August 18, 2025 11:29 — with GitHub Actions Failure
@dpohr
dpohr requested a review from marwen-abid August 18, 2025 11:38
@dpohr
dpohr had a problem deploying to Anchor Integration Tests August 26, 2025 08:47 — with GitHub Actions Failure
@dpohr
dpohr temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) August 26, 2025 08:47 — with GitHub Actions Inactive
@dpohr
dpohr temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) August 26, 2025 09:00 — with GitHub Actions Inactive
@dpohr
dpohr had a problem deploying to Anchor Integration Tests August 26, 2025 09:00 — with GitHub Actions Failure
@dpohr
dpohr had a problem deploying to Anchor Integration Tests August 26, 2025 09:10 — with GitHub Actions Failure
@dpohr
dpohr temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) August 26, 2025 09:10 — with GitHub Actions Inactive
@dpohr
dpohr merged commit adaee19 into sdp-sep-wallet-registration Aug 26, 2025
11 of 12 checks passed
@dpohr
dpohr deleted the SDP-1801-add-ff-for-enabling-AP branch August 26, 2025 09:19
hypekostas pushed a commit that referenced this pull request Aug 28, 2026
Bumps the minor-and-patch group with 8 updates:
| Package | From | To |
| --- | --- | --- |
| [github.com/aws/aws-sdk-go-v2](https://github.com/aws/aws-sdk-go-v2) | `1.43.5` | `1.43.6` |
| [github.com/aws/aws-sdk-go-v2/config](https://github.com/aws/aws-sdk-go-v2) | `1.32.36` | `1.32.37` |
| [github.com/aws/aws-sdk-go-v2/credentials](https://github.com/aws/aws-sdk-go-v2) | `1.19.35` | `1.19.36` |
| [github.com/aws/aws-sdk-go-v2/service/ses](https://github.com/aws/aws-sdk-go-v2) | `1.37.5` | `1.37.6` |
| [github.com/aws/aws-sdk-go-v2/service/sns](https://github.com/aws/aws-sdk-go-v2) | `1.42.5` | `1.42.6` |
| [github.com/fxamacker/cbor/v2](https://github.com/fxamacker/cbor) | `2.9.2` | `2.9.3` |
| [github.com/sirupsen/logrus](https://github.com/sirupsen/logrus) | `1.9.4` | `1.10.1` |
| [github.com/stretchr/testify](https://github.com/stretchr/testify) | `1.11.1` | `1.12.0` |
Updates `github.com/aws/aws-sdk-go-v2` from 1.43.5 to 1.43.6
### Commits
* [`168c59c`](aws/aws-sdk-go-v2@168c59c)
  Release 2026-08-14
* [`95fee35`](aws/aws-sdk-go-v2@95fee35)
  Regenerated Clients
* [`12e7ccd`](aws/aws-sdk-go-v2@12e7ccd)
  Update endpoints model
* [`93e74b8`](aws/aws-sdk-go-v2@93e74b8)
  Update API model
* [`fe3cb6a`](aws/aws-sdk-go-v2@fe3cb6a)
  fix: close original S3 response body in 200-error handling ([#3517](https://redirect.github.com/aws/aws-sdk-go-v2/issues/3517))
* [`800a56b`](aws/aws-sdk-go-v2@800a56b)
  Release 2026-08-13
* [`e739a5d`](aws/aws-sdk-go-v2@e739a5d)
  Regenerated Clients
* [`f75a3c4`](aws/aws-sdk-go-v2@f75a3c4)
  Update API model
* [`b0973f9`](aws/aws-sdk-go-v2@b0973f9)
  delete stale response snapshots ([#3516](https://redirect.github.com/aws/aws-sdk-go-v2/issues/3516))
* [`c3679fb`](aws/aws-sdk-go-v2@c3679fb)
  remove broken internal changelog recipe ([#3515](https://redirect.github.com/aws/aws-sdk-go-v2/issues/3515))
* Additional commits viewable in [compare
  view](aws/aws-sdk-go-v2@v1.43.5...v1.43.6)
  
Updates `github.com/aws/aws-sdk-go-v2/config` from 1.32.36 to 1.32.37
### Commits
* [`168c59c`](aws/aws-sdk-go-v2@168c59c)
  Release 2026-08-14
* [`95fee35`](aws/aws-sdk-go-v2@95fee35)
  Regenerated Clients
* [`12e7ccd`](aws/aws-sdk-go-v2@12e7ccd)
  Update endpoints model
* [`93e74b8`](aws/aws-sdk-go-v2@93e74b8)
  Update API model
* [`fe3cb6a`](aws/aws-sdk-go-v2@fe3cb6a)
  fix: close original S3 response body in 200-error handling ([#3517](https://redirect.github.com/aws/aws-sdk-go-v2/issues/3517))
* [`800a56b`](aws/aws-sdk-go-v2@800a56b)
  Release 2026-08-13
* [`e739a5d`](aws/aws-sdk-go-v2@e739a5d)
  Regenerated Clients
* [`f75a3c4`](aws/aws-sdk-go-v2@f75a3c4)
  Update API model
* [`b0973f9`](aws/aws-sdk-go-v2@b0973f9)
  delete stale response snapshots ([#3516](https://redirect.github.com/aws/aws-sdk-go-v2/issues/3516))
* [`c3679fb`](aws/aws-sdk-go-v2@c3679fb)
  remove broken internal changelog recipe ([#3515](https://redirect.github.com/aws/aws-sdk-go-v2/issues/3515))
* Additional commits viewable in [compare
  view](aws/aws-sdk-go-v2@config/v1.32.36...config/v1.32.37)
  
Updates `github.com/aws/aws-sdk-go-v2/credentials` from 1.19.35 to
1.19.36
### Commits
* [`168c59c`](aws/aws-sdk-go-v2@168c59c)
  Release 2026-08-14
* [`95fee35`](aws/aws-sdk-go-v2@95fee35)
  Regenerated Clients
* [`12e7ccd`](aws/aws-sdk-go-v2@12e7ccd)
  Update endpoints model
* [`93e74b8`](aws/aws-sdk-go-v2@93e74b8)
  Update API model
* [`fe3cb6a`](aws/aws-sdk-go-v2@fe3cb6a)
  fix: close original S3 response body in 200-error handling ([#3517](https://redirect.github.com/aws/aws-sdk-go-v2/issues/3517))
* [`800a56b`](aws/aws-sdk-go-v2@800a56b)
  Release 2026-08-13
* [`e739a5d`](aws/aws-sdk-go-v2@e739a5d)
  Regenerated Clients
* [`f75a3c4`](aws/aws-sdk-go-v2@f75a3c4)
  Update API model
* [`b0973f9`](aws/aws-sdk-go-v2@b0973f9)
  delete stale response snapshots ([#3516](https://redirect.github.com/aws/aws-sdk-go-v2/issues/3516))
* [`c3679fb`](aws/aws-sdk-go-v2@c3679fb)
  remove broken internal changelog recipe ([#3515](https://redirect.github.com/aws/aws-sdk-go-v2/issues/3515))
* Additional commits viewable in [compare
  view](aws/aws-sdk-go-v2@credentials/v1.19.35...credentials/v1.19.36)
  
Updates `github.com/aws/aws-sdk-go-v2/service/ses` from 1.37.5 to 1.37.6
### Commits
* [`b9b0c65`](aws/aws-sdk-go-v2@b9b0c65)
  Release 2025-10-16
* [`e2bc8a0`](aws/aws-sdk-go-v2@e2bc8a0)
  Regenerated Clients
* [`8691ee3`](aws/aws-sdk-go-v2@8691ee3)
  Update API model
* [`51e8a3f`](aws/aws-sdk-go-v2@51e8a3f)
  bump to go1.23 ([#3211](https://redirect.github.com/aws/aws-sdk-go-v2/issues/3211))
* [`ad2d36c`](aws/aws-sdk-go-v2@ad2d36c)
  Release 2025-10-15
* [`19a35d6`](aws/aws-sdk-go-v2@19a35d6)
  Regenerated Clients
* [`35cb02f`](aws/aws-sdk-go-v2@35cb02f)
  Update endpoints model
* [`f673a1b`](aws/aws-sdk-go-v2@f673a1b)
  Update API model
* [`48421fd`](aws/aws-sdk-go-v2@48421fd)
  Release 2025-10-14
* [`fedcba7`](aws/aws-sdk-go-v2@fedcba7)
  Regenerated Clients
* Additional commits viewable in [compare
  view](aws/aws-sdk-go-v2@service/pi/v1.37.5...service/fis/v1.37.6)
  
Updates `github.com/aws/aws-sdk-go-v2/service/sns` from 1.42.5 to 1.42.6
### Commits
* [`69ff935`](aws/aws-sdk-go-v2@69ff935)
  Release 2025-09-19
* [`d2c28e7`](aws/aws-sdk-go-v2@d2c28e7)
  Regenerated Clients
* [`a50ca9d`](aws/aws-sdk-go-v2@a50ca9d)
  Update endpoints model
* [`6884609`](aws/aws-sdk-go-v2@6884609)
  Update API model
* [`049d803`](aws/aws-sdk-go-v2@049d803)
  Release 2025-09-18
* [`591f16a`](aws/aws-sdk-go-v2@591f16a)
  Regenerated Clients
* [`db300ee`](aws/aws-sdk-go-v2@db300ee)
  Update API model
* [`e922702`](aws/aws-sdk-go-v2@e922702)
  Release 2025-09-17
* [`eb4e5f2`](aws/aws-sdk-go-v2@eb4e5f2)
  Regenerated Clients
* [`51fb77b`](aws/aws-sdk-go-v2@51fb77b)
  Update API model
* Additional commits viewable in [compare
  view](aws/aws-sdk-go-v2@service/amp/v1.42.5...service/sqs/v1.42.6)
  
Updates `github.com/fxamacker/cbor/v2` from 2.9.2 to 2.9.3
### Release notes
*Sourced from [github.com/fxamacker/cbor/v2's
releases](https://github.com/fxamacker/cbor/releases).*

> ## v2.9.3
>
> This release fixes a potential panic when decoding into a
> `time.Time` from a CBOR byte string, map, or array under
> certain conditions.
>
> Not affected: standard CBOR time data (RFC 8949 tag 0 or tag 1), and
> decoders configured with `timeTag = DecTagRequired`.
>
> Upgrading to v2.9.3 is recommended.
>
> The panic stack trace was publicly reported on 2026-08-17, and the
> fix was released the same day. Fuzz testing was extended to cover this
> class of bug, and fuzzing of v2.9.3 is ongoing.
>
> ## What's Changed
>
> * Skip data item when decoding to time.Time fails under certain
>   conditions by [`@​fxamacker`](https://github.com/fxamacker) in [fxamacker/cbor#803](https://redirect.github.com/fxamacker/cbor/pull/803)
>
> **Full Changelog**: <fxamacker/cbor@v2.9.2...v2.9.3>

### Commits
* [`f0c90b6`](fxamacker/cbor@f0c90b6)
  Merge pull request [#803](https://redirect.github.com/fxamacker/cbor/issues/803)
  from fxamacker/fxamacker/fix-unmarshal-to-time
* [`c20692a`](fxamacker/cbor@c20692a)
  Skip data item when decoding to time.Time fails
* See full diff in [compare
  view](fxamacker/cbor@v2.9.2...v2.9.3)
  
Updates `github.com/sirupsen/logrus` from 1.9.4 to 1.10.1
### Release notes
*Sourced from [github.com/sirupsen/logrus's
releases](https://github.com/sirupsen/logrus/releases).*

> ## v1.10.1
>
> # Logrus v1.10.1
>
> This patch release fixes two issues in field formatting and
> handling:
>
> * Fix a regression introduced in v1.10.0 where
>   `TextFormatter` could panic
>   when formatting nil or panicking `error` and
>   `fmt.Stringer` values.
> * Allow function-backed values implementing `error` to be
>   used with
>   `WithError`, `WithField`, and
>   `WithFields`.
>
> Dependency Changes
>
> * update github.com/stretchr/testify to v1.12.0
>
> **Full Changelog**: <sirupsen/logrus@v1.10.0...v1.10.1>
>
> ## v1.10.0
>
> # Logrus v1.10.0
>
> This release focuses on substantial performance improvements,
> concurrency correctness, and better interoperability with modern Go
> logging APIs.
>
> ## 🚀 Performance
>
> Major improvements across `TextFormatter`, entry handling,
> and common logger paths:
>
> * ~17% lower geomean runtime across the benchmark suite
> * ~27% higher geomean formatter throughput
> * Common enabled logging paths are ~30–44% faster
> * `WithError` is ~40% faster
> * Chained fields are ~46% faster
> * `TextFormatter` paths are up to ~40% faster
> * Allocation counts are reduced by ~25–74% across measured
>   `TextFormatter` cases, with the largest reductions in colored
>   output
>
> The improvements also show up in complete logger paths:
>
> * Logger + `TextFormatter` is ~31% faster, with ~24% fewer
>   allocations
> * Logger + `JSONFormatter` is ~21% faster, with ~10% fewer
>   allocations
>
> `JSONFormatter` itself remains largely unchanged in
> runtime performance, with small allocation reductions.
>
> ## 🔄 `log/slog` interoperability
>
> v1.10 adds bidirectional interoperability between Logrus and Go's
> `log/slog`:
>
> * A Logrus `slog` hook can forward existing Logrus entries
>   to an `slog` logger.
> * `hooks/slog.NewHandler` implements
>   `slog.Handler`, allowing `log/slog` records to use
>   an existing Logrus logger and its hooks, formatter, and output.
> * The handler preserves levels, fields, groups, context, record
>   timestamps, and optionally caller information.
> * Caller reporting is configured per handler, without requiring
>   Logrus's logger-wide `ReportCaller` option.
> * Custom `slog` levels can be mapped to Logrus levels.

... (truncated)

### Changelog
*Sourced from [github.com/sirupsen/logrus's
changelog](https://github.com/sirupsen/logrus/blob/master/CHANGELOG.md).*

> ## 1.10.1
>
> Fixes:
>
> * Fix a regression introduced in v1.10.0 where
>   `TextFormatter` could panic
>   when formatting nil or panicking `error` and
>   `fmt.Stringer` values.
> * Allow function-backed implementations of `error` as field
>   values.
>
> ## 1.10.0
>
> Fixes:
>
> * Fix reentrant logging deadlocks in formatter paths.
> * Fix race conditions in formatter and entry handling.
> * Fix generic `Log`, `Logf`, `Logln`,
>   and `LogFn` methods unexpectedly
>   panicking when called with `PanicLevel`. Use the
>   corresponding `Panic`
>   methods when panic behavior is desired.
> * Improve concurrency safety around formatter and hook access.
>
> Features:
>
> * Add `slog` hook for forwarding Logrus entries to
>   `log/slog`.
> * Add `slog.Handler` for forwarding `log/slog`
>   records to a Logrus logger,
>   including levels, fields, groups, context, time, and optional caller
>   reporting. The hook and handler can also be combined to help migrate
>   between Logrus and `log/slog`.
> * Add minimal, composable logging interfaces for each log level. This
>   enables
>   consumers to depend on narrower interfaces, making it easier to
>   substitute
>   or adapt logging implementations.
> * Allow `Entry.Caller` to be set explicitly and preserve it
>   across derived
>   entries, enabling custom caller detection without Logrus overwriting
>   caller information when `ReportCaller` is enabled.
>
> Changed:
>
> * Raise minimum supported Go version to 1.23.
> * TextFormatter now renders `[]byte` values as raw/quoted
>   strings instead of slice-of-ints.
> * TextFormatter now uses distinct dimmed colors for debug and trace
>   output.
> * TextFormatter now automatically enables colors on Windows terminals
>   with ANSI support,
>   matching the behavior on other platforms.
> * `Entry.HasCaller` is now deprecated in favor of checking
>   `Entry.Caller` directly.
> * Deprecated `MutexWrap`, which was unintentionally exposed
>   as public API.
>   It remains available as an alias for compatibility but should not be
>   used
>   directly.
>
> Performance:
>
> * Significantly improve TextFormatter performance and reduce
>   allocations.
> * Optimize common Entry and Logger hot paths.
> * Reduce allocations in caller reporting.

... (truncated)

### Commits
* [`8b673a9`](sirupsen/logrus@8b673a9)
  Merge pull request [#1583](https://redirect.github.com/sirupsen/logrus/issues/1583)
  from thaJeztah/release\_1.10.1
* [`0b920ad`](sirupsen/logrus@0b920ad)
  Merge pull request [#1584](https://redirect.github.com/sirupsen/logrus/issues/1584)
  from thaJeztah/more\_coverage
* [`5e20694`](sirupsen/logrus@5e20694)
  TextFormatter: cover nil pointer method receivers
* [`8312732`](sirupsen/logrus@8312732)
  update changelog for v1.10.1
* [`e987a40`](sirupsen/logrus@e987a40)
  Merge pull request [#1582](https://redirect.github.com/sirupsen/logrus/issues/1582)
  from thaJeztah/panic\_handler
* [`17d574b`](sirupsen/logrus@17d574b)
  TextFormatter: recover panics from Error and String methods
* [`134c80f`](sirupsen/logrus@134c80f)
  Merge pull request [#1579](https://redirect.github.com/sirupsen/logrus/issues/1579)
  from thaJeztah/err\_handling
* [`7350f42`](sirupsen/logrus@7350f42)
  logger: WithError: wrap logger.WithError for consistency
* [`b3369d2`](sirupsen/logrus@b3369d2)
  entry: allow function-backed error fields
* [`1080083`](sirupsen/logrus@1080083)
  Merge pull request [#1578](https://redirect.github.com/sirupsen/logrus/issues/1578)
  from thaJeztah/err\_handling\_tests
* Additional commits viewable in [compare
  view](sirupsen/logrus@v1.9.4...v1.10.1)
  
Updates `github.com/stretchr/testify` from 1.11.1 to 1.12.0
### Release notes
*Sourced from [github.com/stretchr/testify's
releases](https://github.com/stretchr/testify/releases).*

> ## v1.12.0
>
> ## What's Changed
>
> ### Functional Changes
>
> * assert: make \*AssertionFunc types just aliases by [`@​dolmen`](https://github.com/dolmen) in [stretchr/testify#1563](https://redirect.github.com/stretchr/testify/pull/1563)
>
> ### Fixes
>
> * mock: avoid panic when expected type is nil in Arguments.Diff by [`@​mutaiib`](https://github.com/mutaiib) in [stretchr/testify#1775](https://redirect.github.com/stretchr/testify/pull/1775)
> * mock: revert to pre-v1.11.0 argument matching behavior for mutating
>   stringers by [`@​brackendawson`](https://github.com/brackendawson)
>   in [stretchr/testify#1786](https://redirect.github.com/stretchr/testify/pull/1786)
> * suite: validate method signatures and continue execution for valid
>   tests by [`@​vyas-git`](https://github.com/vyas-git) in [stretchr/testify#1665](https://redirect.github.com/stretchr/testify/pull/1665)
> * assert.PanicsWithError: report error message by [`@​olivergondza`](https://github.com/olivergondza)
>   in [stretchr/testify#1400](https://redirect.github.com/stretchr/testify/pull/1400)
> * assert: IsIncreasing et al can return false w/out failing by [`@​brackendawson`](https://github.com/brackendawson)
>   in [stretchr/testify#1787](https://redirect.github.com/stretchr/testify/pull/1787)
> * add type to error message of assert.Same by [`@​egawata`](https://github.com/egawata) in [stretchr/testify#1792](https://redirect.github.com/stretchr/testify/pull/1792)
> * mock.AssertExpectationsForObjects fix panic with wrong testObject
>   type. by [`@​brackendawson`](https://github.com/brackendawson)
>   in [stretchr/testify#1795](https://redirect.github.com/stretchr/testify/pull/1795)
> * assert: truncate very long objects in test failure messages by [`@​brackendawson`](https://github.com/brackendawson)
>   in [stretchr/testify#1646](https://redirect.github.com/stretchr/testify/pull/1646)
> * assert: fix NotSubset error messages using %#v instead of %q (fixes
>   [#1800](https://redirect.github.com/stretchr/testify/issues/1800))
>   by [`@​nghiack7`](https://github.com/nghiack7) in
>   [stretchr/testify#1888](https://redirect.github.com/stretchr/testify/pull/1888)
> * suite: prevent panic when SetupTest skips with HandleStats by [`@​blackwell-systems`](https://github.com/blackwell-systems)
>   in [stretchr/testify#1877](https://redirect.github.com/stretchr/testify/pull/1877)
>
> ### Documentation, Build & CI
>
> * CI: test also with Go 1.23 by [`@​dolmen`](https://github.com/dolmen) in [stretchr/testify#1783](https://redirect.github.com/stretchr/testify/pull/1783)
> * Vendor unmaintained github.com/pmezard/go-difflib by [`@​brackendawson`](https://github.com/brackendawson)
>   in [stretchr/testify#1708](https://redirect.github.com/stretchr/testify/pull/1708)
> * Promote ccoVeille to maintainer by [`@​brackendawson`](https://github.com/brackendawson)
>   in [stretchr/testify#1784](https://redirect.github.com/stretchr/testify/pull/1784)
> * build(deps): bump actions/setup-go from 5 to 6 by [`@​dependabot`](https://github.com/dependabot)[bot]
>   in [stretchr/testify#1790](https://redirect.github.com/stretchr/testify/pull/1790)
> * assert.YAMLEq: Document mutlidoc behavior by [`@​brackendawson`](https://github.com/brackendawson)
>   in [stretchr/testify#1791](https://redirect.github.com/stretchr/testify/pull/1791)
> * \_codegen: copy dependency github.com/ernesto-jimenez/gogen/imports
>   by [`@​dolmen`](https://github.com/dolmen) in [stretchr/testify#1782](https://redirect.github.com/stretchr/testify/pull/1782)
> * doc: remove ineffective inline code blocks by [`@​brackendawson`](https://github.com/brackendawson)
>   in [stretchr/testify#1714](https://redirect.github.com/stretchr/testify/pull/1714)
> * Tag generated assertions as non-generated in new .gitattributes by
>   [`@​ubunatic`](https://github.com/ubunatic) in [stretchr/testify#1815](https://redirect.github.com/stretchr/testify/pull/1815)
> * chore: vendor go-spew from <https://github.com/davecgh/go-spew>
>   by [`@​ccoVeille`](https://github.com/ccoVeille)
>   in [stretchr/testify#1827](https://redirect.github.com/stretchr/testify/pull/1827)
> * require: fix godoc generation for assertions returning a bool by [`@​Baxromumarov`](https://github.com/Baxromumarov)
>   in [stretchr/testify#1850](https://redirect.github.com/stretchr/testify/pull/1850)
> * docs(require): correct example usage to use assert.CollectT
>   (require.CollectT does not exist) by [`@​a2not`](https://github.com/a2not) in [stretchr/testify#1821](https://redirect.github.com/stretchr/testify/pull/1821)
> * docs: Fix EventuallyWithTf documentation with proper placement of
>   formatting arguments by [`@​a2not`](https://github.com/a2not) in [stretchr/testify#1842](https://redirect.github.com/stretchr/testify/pull/1842)
> * EMERITUS.md: add [`@​tylerb`](https://github.com/tylerb) by [`@​dolmen`](https://github.com/dolmen) in [stretchr/testify#1812](https://redirect.github.com/stretchr/testify/pull/1812)
> * CI: test also with Go 1.24 by [`@​alexandear`](https://github.com/alexandear) in [stretchr/testify#1856](https://redirect.github.com/stretchr/testify/pull/1856)
> * deps: bump objx to v0.5.3 and remove dependency cycle issue by [`@​ccoVeille`](https://github.com/ccoVeille) in [stretchr/testify#1823](https://redirect.github.com/stretchr/testify/pull/1823)
> * CI: upgrade GitHub Actions and pin hashes by [`@​SuperQ`](https://github.com/SuperQ) in [stretchr/testify#1883](https://redirect.github.com/stretchr/testify/pull/1883)
> * CI: add \_readme-gofmt tool to reformat Go code in README by [`@​dolmen`](https://github.com/dolmen) in [stretchr/testify#1889](https://redirect.github.com/stretchr/testify/pull/1889)
> * CI: add check of GitHub Action pinned hashes against tag by [`@​dolmen`](https://github.com/dolmen) in [stretchr/testify#1885](https://redirect.github.com/stretchr/testify/pull/1885)
> * \_codegen: modernize by [`@​dolmen`](https://github.com/dolmen) in [stretchr/testify#1890](https://redirect.github.com/stretchr/testify/pull/1890)
> * build(deps): bump actions/checkout from 6.0.2 to 6.0.3 by [`@​dependabot`](https://github.com/dependabot)[bot]
>   in [stretchr/testify#1906](https://redirect.github.com/stretchr/testify/pull/1906)
> * mock: Mock.Return does not exist anymore by [`@​Kentzo`](https://github.com/Kentzo) in [stretchr/testify#1905](https://redirect.github.com/stretchr/testify/pull/1905)
>
> ## New Contributors
>
> * [`@​mutaiib`](https://github.com/mutaiib) made
>   their first contribution in [stretchr/testify#1775](https://redirect.github.com/stretchr/testify/pull/1775)
> * [`@​vyas-git`](https://github.com/vyas-git)
>   made their first contribution in [stretchr/testify#1665](https://redirect.github.com/stretchr/testify/pull/1665)
> * [`@​olivergondza`](https://github.com/olivergondza)
>   made their first contribution in [stretchr/testify#1400](https://redirect.github.com/stretchr/testify/pull/1400)
> * [`@​egawata`](https://github.com/egawata) made
>   their first contribution in [stretchr/testify#1792](https://redirect.github.com/stretchr/testify/pull/1792)
> * [`@​ubunatic`](https://github.com/ubunatic)
>   made their first contribution in [stretchr/testify#1815](https://redirect.github.com/stretchr/testify/pull/1815)
> * [`@​Baxromumarov`](https://github.com/Baxromumarov)
>   made their first contribution in [stretchr/testify#1850](https://redirect.github.com/stretchr/testify/pull/1850)
> * [`@​a2not`](https://github.com/a2not) made
>   their first contribution in [stretchr/testify#1821](https://redirect.github.com/stretchr/testify/pull/1821)

... (truncated)

### Commits
* [`001eb79`](stretchr/testify@001eb79)
  Merge pull request [#1905](https://redirect.github.com/stretchr/testify/issues/1905)
  from Kentzo/patch-1
* [`ad40f38`](stretchr/testify@ad40f38)
  Merge pull request [#1906](https://redirect.github.com/stretchr/testify/issues/1906)
  from stretchr/dependabot/github\_actions/actions/chec...
* [`3bae017`](stretchr/testify@3bae017)
  build(deps): bump actions/checkout from 6.0.2 to 6.0.3
* [`f8c01f3`](stretchr/testify@f8c01f3)
  mock: Mock.Return does not exist anymore
* [`12f8b56`](stretchr/testify@12f8b56)
  Merge pull request [#1563](https://redirect.github.com/stretchr/testify/issues/1563)
  from stretchr/make-AssertionFunc-types-aliases
* [`a11649e`](stretchr/testify@a11649e)
  assert: make \*AssertionFunc type just aliases
* [`dc20f41`](stretchr/testify@dc20f41)
  Merge pull request [#1890](https://redirect.github.com/stretchr/testify/issues/1890)
  from stretchr/dolmen/codegen-modernize
* [`098f8d7`](stretchr/testify@098f8d7)
  \_codegen: use strings.Builder
* [`d2699be`](stretchr/testify@d2699be)
  \_codegen: modernize
* [`a463c8c`](stretchr/testify@a463c8c)
  Merge pull request [#1885](https://redirect.github.com/stretchr/testify/issues/1885)
  from stretchr/dolmen/ci-check-ghactions-hashes
* Additional commits viewable in [compare
  view](stretchr/testify@v1.11.1...v1.12.0)
  
Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
### Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore <dependency name> major version` will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
- `@dependabot ignore <dependency name> minor version` will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
- `@dependabot ignore <dependency name>` will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
- `@dependabot unignore <dependency name>` will remove all of the ignore conditions of the specified dependency
- `@dependabot unignore <dependency name> <ignore condition>` will remove the ignore condition of the specified dependency and ignore conditions

---------
Signed-off-by: dependabot[bot] 
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Konstantinos Rokanas
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants