Skip to content

SDP-1614: Fix wallet creation transaction building - #712

Merged
philipliu merged 2 commits into
feature/c-accountsfrom
philip/sdp-1614-wallet-creation-tx-build
Jun 17, 2025
Merged

SDP-1614: Fix wallet creation transaction building#712
philipliu merged 2 commits into
feature/c-accountsfrom
philip/sdp-1614-wallet-creation-tx-build

Conversation

@philipliu

Copy link
Copy Markdown
Contributor

What

Fetch the account sequence number again after updating the transaction parameters.

Why

It fails with a bad sequence number error, otherwise.

Known limitations

N/A

Checklist

  • Title follows SDP-1234: Add new feature or Chore: Refactor package xyz format. The Jira ticket code was included if available.
  • PR has a focused scope and doesn't mix features with refactoring
  • Tests are included (if applicable)
  • CHANGELOG.md is updated (if applicable)
  • CONFIG/SECRETS changes are updated in helmcharts and deployments (if applicable)
  • Preview deployment works as expected
  • Ready for production

@philipliu
philipliu temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) June 16, 2025 18:28 — with GitHub Actions Inactive
@philipliu
philipliu temporarily deployed to Anchor Integration Tests June 16, 2025 18:28 — with GitHub Actions Inactive
@philipliu
philipliu force-pushed the philip/sdp-1614-wallet-creation-tx-build branch from c85ae8f to bbac115 Compare June 16, 2025 18:30
@philipliu
philipliu temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) June 16, 2025 18:30 — with GitHub Actions Inactive
@philipliu
philipliu temporarily deployed to Anchor Integration Tests June 16, 2025 18:30 — with GitHub Actions Inactive
@stellar-jenkins

Copy link
Copy Markdown

Something went wrong with PR preview build please check

@philipliu
philipliu marked this pull request as ready for review June 16, 2025 18:58
@philipliu
philipliu temporarily deployed to Anchor Integration Tests June 16, 2025 19:02 — with GitHub Actions Inactive
@philipliu
philipliu temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) June 16, 2025 19:02 — with GitHub Actions Inactive

@marwen-abid marwen-abid left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@philipliu
philipliu merged commit 825bf4a into feature/c-accounts Jun 17, 2025
@philipliu
philipliu deleted the philip/sdp-1614-wallet-creation-tx-build branch June 17, 2025 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants