SDP-1614: Generate unique wallet creation tokens - #705
Merged
philipliu merged 6 commits intoJun 13, 2025
Conversation
philipliu
temporarily deployed
to
Anchor Integration Tests
June 12, 2025 17:00 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
philipliu
temporarily deployed
to
Receiver Registration - E2E Integration Tests (Stellar)
June 12, 2025 17:00 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
This comment was marked as duplicate.
This comment was marked as duplicate.
philipliu
force-pushed
the
philip/sdp-1614-update-token-generation
branch
from
June 12, 2025 21:38
4a32139 to
eba549f
Compare
philipliu
temporarily deployed
to
Anchor Integration Tests
June 12, 2025 21:38 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
philipliu
temporarily deployed
to
Receiver Registration - E2E Integration Tests (Stellar)
June 12, 2025 21:38 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
This comment was marked as duplicate.
This comment was marked as duplicate.
philipliu
force-pushed
the
philip/sdp-1614-update-token-generation
branch
from
June 12, 2025 21:52
eba549f to
082774c
Compare
philipliu
temporarily deployed
to
Anchor Integration Tests
June 12, 2025 21:52 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
philipliu
temporarily deployed
to
Receiver Registration - E2E Integration Tests (Stellar)
June 12, 2025 21:52 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
philipliu
commented
Jun 12, 2025
| MtnDBConnectionPool db.DBConnectionPool | ||
| AnchorPlatformBaseSepURL string | ||
| MessageDispatcher message.MessageDispatcherInterface | ||
| EmbeddedWalletService services.EmbeddedWalletServiceInterface |
Contributor
Author
There was a problem hiding this comment.
I need to make sure that this is properly injected after #704 is merged.
philipliu
marked this pull request as ready for review
June 12, 2025 22:04
marwen-abid
reviewed
Jun 13, 2025
| CREATE TABLE embedded_wallets ( | ||
| token VARCHAR(36) PRIMARY KEY DEFAULT public.uuid_generate_v4(), | ||
| token VARCHAR(36) PRIMARY KEY, | ||
| tenant_id VARCHAR(36) NOT NULL, |
Collaborator
There was a problem hiding this comment.
🏗️ The presence of tenant_id here is indicative that there may be a logic/architecture issue. We shouldn't need to reference tenant ids in these tables, as this whole schema belongs to the same tenant.
Whenever we query this embedded_wallets table, we're only getting results for this tenant_id. So we shouldn't need to be passing around the tenant ID to any of the Wallet methods or store it in any of the tables.
Contributor
Author
There was a problem hiding this comment.
Yeah, this makes sense. Here's the PR #707
marwen-abid
approved these changes
Jun 13, 2025
philipliu
temporarily deployed
to
Anchor Integration Tests
June 13, 2025 19:48 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
philipliu
temporarily deployed
to
Receiver Registration - E2E Integration Tests (Stellar)
June 13, 2025 19:48 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
philipliu
force-pushed
the
philip/sdp-1614-update-token-generation
branch
from
June 13, 2025 19:52
15717da to
aa75f9d
Compare
philipliu
temporarily deployed
to
Anchor Integration Tests
June 13, 2025 19:52 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
philipliu
temporarily deployed
to
Receiver Registration - E2E Integration Tests (Stellar)
June 13, 2025 19:52 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
philipliu
had a problem deploying
to
Anchor Integration Tests
June 13, 2025 20:00 — with
GitHub Actions
Failure
GitHub Actions
Failure
philipliu
temporarily deployed
to
Receiver Registration - E2E Integration Tests (Stellar)
June 13, 2025 20:00 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
philipliu
temporarily deployed
to
Anchor Integration Tests
June 13, 2025 20:05 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This implements the wallet creation token generation as part of the receiver invite flow.
Why
Tokens are currently hardcoded.
Known limitations
N/A
Checklist
SDP-1234: Add new featureorChore: Refactor package xyzformat. The Jira ticket code was included if available.CHANGELOG.mdis updated (if applicable)