SDP-1614: Update configuration management for embedded wallets by philipliu · Pull Request #704 · stellar/stellar-disbursement-platform-backend

philipliu · 2025-06-10T22:59:03Z

What

This updates the configuration management for the RPC-dependent features. It introduces the following flags:

Embedded Wallets

enable-embedded-wallets: Enables wallet creation and transaction sponsorship
- requires RPC_URL and embedded-wallets-wasm-hash
embedded-wallets-wasm-hash: Embedded wallet contract Wasm hash

Contract Account Support

enable-sep45: Enables SEP-45 authentication used by known contract accounts and embedded wallets
- requires sep45-contract-id and RPC_URL

Why

Previously, features such as SEP-45 or embedded wallets APIs were gated behind the presence of the RPC_URL flag. These features had their configurations that needed to be set, but the relationship between them and the RPC_URL was not clear.

Known limitations

N/A

Checklist

Title follows SDP-1234: Add new feature or Chore: Refactor package xyz format. The Jira ticket code was included if available.
PR has a focused scope and doesn't mix features with refactoring
Tests are included (if applicable)
CHANGELOG.md is updated (if applicable)
CONFIG/SECRETS changes are updated in helmcharts and deployments (if applicable)
Preview deployment works as expected
Ready for production

stellar-jenkins · 2025-06-10T23:02:06Z

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr704.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr704.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr704.previews.kube001.services.stellar-ops.com

stellar-jenkins · 2025-06-11T15:36:32Z

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr704.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr704.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr704.previews.kube001.services.stellar-ops.com

…ts-config

stellar-jenkins · 2025-06-11T21:43:03Z

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr704.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr704.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr704.previews.kube001.services.stellar-ops.com

marwen-abid

LGTM! Great changes 🎉

marwen-abid · 2025-06-13T00:47:20Z

+			return fmt.Errorf("error creating embedded wallet service: %w", err)
+		}


Suggested change

return fmt.Errorf("error creating embedded wallet service: %w", err)

}

return fmt.Errorf("creating embedded wallet service: %w", err)

}

We have several error logs starting with error in this file, so I added it for consistency; however, we should probably remove them. I can open another PR on develop.

marwen-abid · 2025-06-13T00:52:40Z

 	}

+	// Setup Embedded Wallet Service (only if enabled)
+	if opts.EnableEmbeddedWallets {


💡Maybe we should add an Info/Debug log here to say that Enable Embedded Wallets is enabled for this runtime.

marwen-abid · 2025-06-13T00:54:02Z

-	// Feature specific validation
-	if opts.Sep45ContractId != "" && opts.RpcConfig.RPCUrl == "" {
-		return fmt.Errorf("RPC URL must be set when SEP-45 contract ID is set")
+	// RPC-dependent feature validation


👍 Nice! this looks clean.

marwen-abid · 2025-06-13T00:57:25Z

+					EmbeddedWalletService: o.EmbeddedWalletService,
+				}
+				r.Post("/", walletCreationHandler.CreateWallet)
+				r.Get("/status", walletCreationHandler.GetWallet)


🧪 Can you add these new endpoints to Test_handleHTTP_authenticatedEndpoints in serve_test.go ?

…ts-config

stellar-jenkins · 2025-06-13T15:27:23Z

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr704.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr704.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr704.previews.kube001.services.stellar-ops.com

philipliu temporarily deployed to Anchor Integration Tests June 10, 2025 22:59 — with GitHub Actions Inactive

philipliu temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) June 10, 2025 22:59 — with GitHub Actions Inactive

github-actions Bot assigned philipliu Jun 10, 2025

philipliu force-pushed the philip/sdp-1614-embedded-wallets-config branch from 72c36b5 to fc44398 Compare June 10, 2025 23:19

philipliu temporarily deployed to Anchor Integration Tests June 10, 2025 23:19 — with GitHub Actions Inactive

philipliu temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) June 10, 2025 23:19 — with GitHub Actions Inactive

This comment was marked as duplicate.

Sign in to view

philipliu force-pushed the philip/sdp-1614-embedded-wallets-config branch from fc44398 to ba3a878 Compare June 11, 2025 00:37

philipliu temporarily deployed to Anchor Integration Tests June 11, 2025 00:37 — with GitHub Actions Inactive

philipliu temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) June 11, 2025 00:37 — with GitHub Actions Inactive

This comment was marked as duplicate.

Sign in to view

Update embedded wallets configuration

a9a8e43

philipliu force-pushed the philip/sdp-1614-embedded-wallets-config branch from ba3a878 to a9a8e43 Compare June 11, 2025 15:33

philipliu temporarily deployed to Anchor Integration Tests June 11, 2025 15:33 — with GitHub Actions Inactive

philipliu temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) June 11, 2025 15:33 — with GitHub Actions Inactive

philipliu marked this pull request as ready for review June 11, 2025 15:41

philipliu added 2 commits June 11, 2025 17:37

Merge branch 'feature/c-accounts' into philip/sdp-1614-embedded-walle…

b42089a

…ts-config

Fix embedded_wallet_serivce_test

f849e52

philipliu temporarily deployed to Anchor Integration Tests June 11, 2025 21:39 — with GitHub Actions Inactive

philipliu temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) June 11, 2025 21:39 — with GitHub Actions Inactive

philipliu mentioned this pull request Jun 12, 2025

SDP-1614: Generate unique wallet creation tokens #705

Merged

7 tasks

marwen-abid approved these changes Jun 13, 2025

View reviewed changes

philipliu added 2 commits June 13, 2025 11:09

Merge branch 'feature/c-accounts' into philip/sdp-1614-embedded-walle…

4c8c274

…ts-config

PR comments

308a627

philipliu temporarily deployed to Anchor Integration Tests June 13, 2025 15:24 — with GitHub Actions Inactive

philipliu temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) June 13, 2025 15:24 — with GitHub Actions Inactive

philipliu merged commit 77df230 into feature/c-accounts Jun 13, 2025

philipliu deleted the philip/sdp-1614-embedded-wallets-config branch June 13, 2025 15:50

philipliu mentioned this pull request Jun 23, 2025

SDP-1607: Update helm chart #722

Merged

7 tasks

Navigation Menu

Uh oh!

SDP-1614: Update configuration management for embedded wallets - #704

SDP-1614: Update configuration management for embedded wallets#704
philipliu merged 5 commits into
feature/c-accountsfrom
philip/sdp-1614-embedded-wallets-config

philipliu commented Jun 10, 2025 •

edited

Loading

Uh oh!

stellar-jenkins commented Jun 10, 2025

Uh oh!

This comment was marked as duplicate.

This comment was marked as duplicate.

stellar-jenkins commented Jun 11, 2025

Uh oh!

stellar-jenkins commented Jun 11, 2025

Uh oh!

marwen-abid left a comment

Uh oh!

marwen-abid Jun 13, 2025

Uh oh!

philipliu Jun 13, 2025

Uh oh!

marwen-abid Jun 13, 2025

Uh oh!

marwen-abid Jun 13, 2025

Uh oh!

marwen-abid Jun 13, 2025

Uh oh!

stellar-jenkins commented Jun 13, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		return fmt.Errorf("error creating embedded wallet service: %w", err)
		}

Uh oh!

Conversation

philipliu commented Jun 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What

Embedded Wallets

Contract Account Support

Why

Known limitations

Checklist

Uh oh!

stellar-jenkins commented Jun 10, 2025

Uh oh!

This comment was marked as duplicate.

This comment was marked as duplicate.

stellar-jenkins commented Jun 11, 2025

Uh oh!

stellar-jenkins commented Jun 11, 2025

Uh oh!

marwen-abid left a comment

Choose a reason for hiding this comment

Uh oh!

marwen-abid Jun 13, 2025

Choose a reason for hiding this comment

Uh oh!

philipliu Jun 13, 2025

Choose a reason for hiding this comment

Uh oh!

marwen-abid Jun 13, 2025

Choose a reason for hiding this comment

Uh oh!

marwen-abid Jun 13, 2025

Choose a reason for hiding this comment

Uh oh!

marwen-abid Jun 13, 2025

Choose a reason for hiding this comment

Uh oh!

stellar-jenkins commented Jun 13, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

philipliu commented Jun 10, 2025 •

edited

Loading