SDP-1614: Create account creation service and request handler by philipliu · Pull Request #686 · stellar/stellar-disbursement-platform-backend

philipliu · 2025-05-19T21:00:36Z

What

This PR implements the embedded wallet account creation service scaffolding. It introduces:

New data model
- EmbeddedWallet manages and tracks the lifecycle of an embedded wallet.
- Records will be created when disbursement instructions are processed, and the corresponding TSS Transaction will be inserted into the TSS database when this API is called.
- Implemented as a separate table from receivers_wallet. receivers_wallet manages the relationship between the receiver and their wallets registration status, while embedded_wallet manages the lifecycle of an embedded wallet. An embedded_wallet is created for a receiver, but it is not associated with the receiver until the wallet is created and the receiver is registered in SEP-24.
New service
- EmbeddedWalletService, creates and checks the status of embedded wallets.
New API handlers
- WalletCreationHandler with REST endpoints;
  - POST /embedded_wallets/ to create a new embedded wallet.
  - GET /embedded_wallets/status?token={token} to check the status of an embedded wallet.

Why

Account creation API

Known limitations

TSS transaction worker not implemented
Dependency injection is not implemented

These will be implemented in other PRs.

Checklist

Title follows SDP-1234: Add new feature or Chore: Refactor package xyz format. The Jira ticket code was included if available.
PR has a focused scope and doesn't mix features with refactoring
Tests are included (if applicable)
CHANGELOG.md is updated (if applicable)
CONFIG/SECRETS changes are updated in helmcharts and deployments (if applicable)
Preview deployment works as expected
Ready for production

stellar-jenkins · 2025-05-19T21:03:40Z

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr686.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr686.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr686.previews.kube001.services.stellar-ops.com

stellar-jenkins · 2025-05-19T21:14:27Z

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr686.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr686.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr686.previews.kube001.services.stellar-ops.com

stellar-jenkins · 2025-05-19T21:38:23Z

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr686.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr686.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr686.previews.kube001.services.stellar-ops.com

stellar-jenkins · 2025-05-20T00:50:23Z

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr686.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr686.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr686.previews.kube001.services.stellar-ops.com

stellar-jenkins · 2025-05-20T14:13:35Z

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr686.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr686.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr686.previews.kube001.services.stellar-ops.com

Copilot

Pull Request Overview

This PR implements a new embedded wallet account creation service, including the data model, service layer, API endpoints, and comprehensive tests.

Added new database table and migration for embedded wallets.
Created EmbeddedWalletService with corresponding unit tests and mocks.
Integrated new REST endpoints for creating and checking wallet status.

Reviewed Changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
stellar-multitenant/internal/provisioning/manager_test.go	Added "embedded_wallets" to the expected tables list.
stellar-multitenant/internal/httphandler/tenants_handler_test.go	Added "embedded_wallets" entry in tenant handler tests.
internal/services/mocks/mock_embedded_wallet_service.go	New mock implementation for EmbeddedWalletService.
internal/services/embedded_wallet_service_test.go	Unit tests for wallet creation and retrieval.
internal/services/embedded_wallet_service.go	Implementation of wallet creation and status retrieval logic.
internal/serve/httphandler/wallet_creation_handler_test.go	Tests for the new wallet creation and status API endpoints.
internal/serve/httphandler/wallet_creation_handler.go	API endpoints for creating and retrieving embedded wallets.
internal/data/models.go	Updated to include the EmbeddedWalletModel.
internal/data/fixtures.go	Introduced fixtures for creating and deleting embedded wallet records.
internal/data/embedded_wallet_test.go	Tests for the embedded wallet data model and update validations.
internal/data/embedded_wallet.go	Implementation of the embedded wallet model including update and column names.
db/migrations/sdp-migrations/2025-05-18.1-create-embedded-wallet.sql	Migration script to create the embedded_wallets table and enum type.

Comments suppressed due to low confidence (1)

internal/data/embedded_wallet.go:54

Consider renaming 'EmbeddWalletColumnNames' to 'EmbeddedWalletColumnNames' to improve clarity and maintain consistency with other naming conventions in the code.

func EmbeddWalletColumnNames(tableReference, resultAlias string) string {

stellar-jenkins · 2025-05-20T14:24:25Z

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr686.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr686.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr686.previews.kube001.services.stellar-ops.com

marcelosalloum

Great job!

I'm leaving a few comments below. Plz DM me if you have any questions.

stellar-jenkins · 2025-05-21T19:35:02Z

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr686.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr686.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr686.previews.kube001.services.stellar-ops.com

marcelosalloum

LGTM! Plz, feel free to merge it after addressing the comments below.

stellar-jenkins · 2025-05-22T21:04:15Z

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr686.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr686.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr686.previews.kube001.services.stellar-ops.com

philipliu temporarily deployed to Anchor Integration Tests May 19, 2025 21:00 — with GitHub Actions Inactive

philipliu temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) May 19, 2025 21:00 — with GitHub Actions Inactive

github-actions Bot assigned philipliu May 19, 2025

philipliu force-pushed the philip/sdp-1614-create-account-service branch from e944246 to 349d333 Compare May 19, 2025 21:11

philipliu temporarily deployed to Anchor Integration Tests May 19, 2025 21:11 — with GitHub Actions Inactive

philipliu temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) May 19, 2025 21:11 — with GitHub Actions Inactive

philipliu force-pushed the philip/sdp-1614-create-account-service branch from 349d333 to 9f984c1 Compare May 19, 2025 21:35

philipliu temporarily deployed to Anchor Integration Tests May 19, 2025 21:35 — with GitHub Actions Inactive

philipliu temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) May 19, 2025 21:35 — with GitHub Actions Inactive

philipliu force-pushed the philip/sdp-1614-create-account-service branch from 9f984c1 to a7b30dd Compare May 20, 2025 00:47

philipliu temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) May 20, 2025 00:47 — with GitHub Actions Inactive

philipliu temporarily deployed to Anchor Integration Tests May 20, 2025 00:47 — with GitHub Actions Inactive

Implement wallet creation service

8caf57d

philipliu force-pushed the philip/sdp-1614-create-account-service branch from a7b30dd to 8caf57d Compare May 20, 2025 14:10

philipliu had a problem deploying to Receiver Registration - E2E Integration Tests (Stellar) May 20, 2025 14:10 — with GitHub Actions Failure

philipliu temporarily deployed to Anchor Integration Tests May 20, 2025 14:10 — with GitHub Actions Inactive

philipliu temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) May 20, 2025 14:11 — with GitHub Actions Inactive

philipliu requested a review from Copilot May 20, 2025 14:15

Copilot AI reviewed May 20, 2025

View reviewed changes

philipliu marked this pull request as ready for review May 20, 2025 14:15

Typo

d00057f

philipliu temporarily deployed to Anchor Integration Tests May 20, 2025 14:21 — with GitHub Actions Inactive

philipliu temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) May 20, 2025 14:21 — with GitHub Actions Inactive

marcelosalloum reviewed May 20, 2025

View reviewed changes

PR comments

0ebd6f8

philipliu temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) May 21, 2025 19:31 — with GitHub Actions Inactive

philipliu temporarily deployed to Anchor Integration Tests May 21, 2025 19:31 — with GitHub Actions Inactive

marcelosalloum approved these changes May 22, 2025

View reviewed changes

PR comments

0b0b7e9

philipliu temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) May 22, 2025 21:01 — with GitHub Actions Inactive

philipliu temporarily deployed to Anchor Integration Tests May 22, 2025 21:01 — with GitHub Actions Inactive

philipliu merged commit f705b04 into feature/c-accounts May 22, 2025

philipliu deleted the philip/sdp-1614-create-account-service branch May 22, 2025 21:15

Uh oh!

Conversation

philipliu commented May 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What

Why

Known limitations

Checklist

Uh oh!

stellar-jenkins commented May 19, 2025

Uh oh!

stellar-jenkins commented May 19, 2025

Uh oh!

stellar-jenkins commented May 19, 2025

Uh oh!

stellar-jenkins commented May 20, 2025

Uh oh!

stellar-jenkins commented May 20, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

stellar-jenkins commented May 20, 2025

Uh oh!

marcelosalloum left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stellar-jenkins commented May 21, 2025

Uh oh!

marcelosalloum left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stellar-jenkins commented May 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

philipliu commented May 19, 2025 •

edited

Loading