SDP-1614: Add wallet creation type to TSS transactions by philipliu · Pull Request #680 · stellar/stellar-disbursement-platform-backend

philipliu · 2025-05-14T03:19:56Z

What

The /embedded-wallets/create endpoint will submit a new type of transaction for wallet creation to TSS. This makes the necessary changes to the Transaction model to support building the TSS workers and scheduled jobs/event handlers on top of it.

Why

TSS will be submitting wallet creation transactions, but it's built for payment transactions and needs to be generalized to support other transaction types. This will require making changes to the transaction type, the transaction worker, and the payment sync jobs and event handlers.

Known limitations

[TODO or N/A]

Checklist

Title follows SDP-1234: Add new feature or Chore: Refactor package xyz format. The Jira ticket code was included if available.
PR has a focused scope and doesn't mix features with refactoring
Tests are included (if applicable)
CHANGELOG.md is updated (if applicable)
CONFIG/SECRETS changes are updated in helmcharts and deployments (if applicable)
Preview deployment works as expected
Ready for production

stellar-jenkins · 2025-05-14T03:23:05Z

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr680.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr680.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr680.previews.kube001.services.stellar-ops.com

stellar-jenkins · 2025-05-15T17:59:52Z

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr680.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr680.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr680.previews.kube001.services.stellar-ops.com

stellar-jenkins · 2025-05-15T18:32:05Z

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr680.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr680.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr680.previews.kube001.services.stellar-ops.com

stellar-jenkins · 2025-05-15T18:36:56Z

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr680.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr680.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr680.previews.kube001.services.stellar-ops.com

stellar-jenkins · 2025-05-15T18:41:59Z

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr680.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr680.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr680.previews.kube001.services.stellar-ops.com

philipliu · 2025-05-15T18:54:28Z

+type Payment struct {
+	AssetCode   string          `db:"asset_code"`
+	AssetIssuer string          `db:"asset_issuer"`
+	Amount      float64         `db:"amount"`
+	Destination string          `db:"destination"`
+	Memo        string          `db:"memo"`
+	MemoType    schema.MemoType `db:"memo_type"`
+}
+
+type WalletCreation struct {
+	PublicKey string `db:"public_key"`
+	WasmHash  string `db:"wasm_hash"`
+}


@marcelosalloum brought up whether or not we want to prefix the columns with the transaction type in the database.

I'm leaning towards not doing it since it doesn't really help too much with code readability IMO since we are accessing these fields through the Transaction struct, and it doesn't do much to prevent misuse of these columns. Instead, we are baking a lot of the safety into the validate method, which is called before the methods are inserted into the database.

stellar-jenkins · 2025-05-22T21:55:14Z

Something went wrong with PR preview build please check

marcelosalloum

LGTM! Plz, feel free to merge it after addressing the comments below.

stellar-jenkins · 2025-05-26T15:42:29Z

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr680.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr680.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr680.previews.kube001.services.stellar-ops.com

stellar-jenkins · 2025-05-26T15:53:38Z

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr680.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr680.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr680.previews.kube001.services.stellar-ops.com

stellar-jenkins · 2025-05-26T16:15:30Z

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr680.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr680.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr680.previews.kube001.services.stellar-ops.com

stellar-jenkins · 2025-05-26T16:17:53Z

Something went wrong with PR preview build please check

stellar-jenkins · 2025-05-26T16:22:20Z

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr680.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr680.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr680.previews.kube001.services.stellar-ops.com

philipliu temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) May 14, 2025 03:20 — with GitHub Actions Inactive

philipliu temporarily deployed to Anchor Integration Tests May 14, 2025 03:20 — with GitHub Actions Inactive

github-actions Bot assigned philipliu May 14, 2025

philipliu force-pushed the philip/sdp-1614-tss-table-update branch from 753b2b4 to 969c16c Compare May 15, 2025 17:56

philipliu temporarily deployed to Anchor Integration Tests May 15, 2025 17:56 — with GitHub Actions Inactive

philipliu temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) May 15, 2025 17:56 — with GitHub Actions Inactive

philipliu force-pushed the philip/sdp-1614-tss-table-update branch from 969c16c to 4881eda Compare May 15, 2025 18:29

philipliu temporarily deployed to Anchor Integration Tests May 15, 2025 18:29 — with GitHub Actions Inactive

philipliu temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) May 15, 2025 18:29 — with GitHub Actions Inactive

philipliu force-pushed the philip/sdp-1614-tss-table-update branch from 4881eda to 58a0cf6 Compare May 15, 2025 18:33

philipliu temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) May 15, 2025 18:33 — with GitHub Actions Inactive

philipliu temporarily deployed to Anchor Integration Tests May 15, 2025 18:33 — with GitHub Actions Inactive

Add wallet creation type to TSS transactions

2591fa9

philipliu force-pushed the philip/sdp-1614-tss-table-update branch from 58a0cf6 to 2591fa9 Compare May 15, 2025 18:39

philipliu temporarily deployed to Anchor Integration Tests May 15, 2025 18:39 — with GitHub Actions Inactive

philipliu temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) May 15, 2025 18:39 — with GitHub Actions Inactive

philipliu marked this pull request as ready for review May 15, 2025 18:44

philipliu commented May 15, 2025

View reviewed changes

Merge branch 'feature/c-accounts' into philip/sdp-1614-tss-table-update

36b934e

philipliu had a problem deploying to Anchor Integration Tests May 22, 2025 21:54 — with GitHub Actions Failure

philipliu had a problem deploying to Receiver Registration - E2E Integration Tests (Stellar) May 22, 2025 21:54 — with GitHub Actions Failure

marcelosalloum approved these changes May 23, 2025

View reviewed changes

Comment thread ...migrations/2025-05-09.0-add-wallet-creation-transactions-to-submitter-transactions-table.sql

Comment thread internal/data/sql_column_config.go

PR comments

f161e51

philipliu temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) May 26, 2025 15:39 — with GitHub Actions Inactive

philipliu temporarily deployed to Anchor Integration Tests May 26, 2025 15:39 — with GitHub Actions Inactive

philipliu temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) May 26, 2025 15:50 — with GitHub Actions Inactive

philipliu temporarily deployed to Anchor Integration Tests May 26, 2025 15:50 — with GitHub Actions Inactive

philipliu force-pushed the philip/sdp-1614-tss-table-update branch from 6fb232c to 3b46aab Compare May 26, 2025 16:12

philipliu temporarily deployed to Anchor Integration Tests May 26, 2025 16:12 — with GitHub Actions Inactive

philipliu temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) May 26, 2025 16:12 — with GitHub Actions Inactive

philipliu force-pushed the philip/sdp-1614-tss-table-update branch from 3b46aab to ee6c59c Compare May 26, 2025 16:15

philipliu temporarily deployed to Anchor Integration Tests May 26, 2025 16:15 — with GitHub Actions Inactive

philipliu temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) May 26, 2025 16:15 — with GitHub Actions Inactive

Fix constraint

0647693

philipliu force-pushed the philip/sdp-1614-tss-table-update branch from ee6c59c to 0647693 Compare May 26, 2025 16:19

philipliu temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) May 26, 2025 16:19 — with GitHub Actions Inactive

philipliu temporarily deployed to Anchor Integration Tests May 26, 2025 16:19 — with GitHub Actions Inactive

philipliu merged commit 6a7a082 into feature/c-accounts May 26, 2025

philipliu deleted the philip/sdp-1614-tss-table-update branch May 26, 2025 16:25

Uh oh!

Conversation

philipliu commented May 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What

Why

Known limitations

Checklist

Uh oh!

stellar-jenkins commented May 14, 2025

Uh oh!

stellar-jenkins commented May 15, 2025

Uh oh!

stellar-jenkins commented May 15, 2025

Uh oh!

stellar-jenkins commented May 15, 2025

Uh oh!

stellar-jenkins commented May 15, 2025

Uh oh!

philipliu May 15, 2025

Choose a reason for hiding this comment

Uh oh!

stellar-jenkins commented May 22, 2025

Uh oh!

marcelosalloum left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

stellar-jenkins commented May 26, 2025

Uh oh!

stellar-jenkins commented May 26, 2025

Uh oh!

stellar-jenkins commented May 26, 2025

Uh oh!

stellar-jenkins commented May 26, 2025

Uh oh!

stellar-jenkins commented May 26, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

philipliu commented May 14, 2025 •

edited

Loading