Skip to content

SDP-1993: Enable RPC for docker testnet - #1023

Merged
marwen-abid merged 2 commits into
feature/c-accountsfrom
bugfix/SDP-1993-enable-rpc-fe-config-testnet
Jan 23, 2026
Merged

SDP-1993: Enable RPC for docker testnet#1023
marwen-abid merged 2 commits into
feature/c-accountsfrom
bugfix/SDP-1993-enable-rpc-fe-config-testnet

Conversation

@marwen-abid

Copy link
Copy Markdown
Collaborator

What

Enable RPC in `/env-config-testnet.js by default to be consistent with the backend

Why

Currently we’re automatically enabling embedded wallets for local development

RPC isn’t enabled for the FE app (wallet), which causes wallet creation to fail silently

Known limitations

[TODO or N/A]

Checklist

  • Title follows SDP-1234: Add new feature or Chore: Refactor package xyz format. The Jira ticket code was included if available.
  • PR has a focused scope and doesn't mix features with refactoring
  • Tests are included (if applicable)
  • CHANGELOG.md is updated (if applicable)
  • CONFIG/SECRETS changes are updated in helmcharts and deployments (if applicable)
  • Preview deployment works as expected
  • Ready for production

@marwen-abid marwen-abid self-assigned this Jan 23, 2026
@marwen-abid
marwen-abid changed the base branch from develop to feature/c-accounts January 23, 2026 20:09
Comment thread dev/env-config-testnet.js
API_URL: "http://localhost:8000",
STELLAR_EXPERT_URL: "https://stellar.expert/explorer/testnet",
HORIZON_URL: "https://horizon-testnet.stellar.org",
USDC_ASSET_ISSUER: "GBBD47IF6LWK7P7MDEVSCWR7DPUWV3NY3DTQEVFL4NAT4AQH3ZLLFLA5",

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not used by the FE.

@philipliu philipliu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. Thanks!

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@marwen-abid
marwen-abid temporarily deployed to Internal SEP Tests January 23, 2026 21:11 — with GitHub Actions Inactive
@marwen-abid
marwen-abid temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) January 23, 2026 21:11 — with GitHub Actions Inactive
@marwen-abid
marwen-abid merged commit 7390240 into feature/c-accounts Jan 23, 2026
16 checks passed
@marwen-abid
marwen-abid deleted the bugfix/SDP-1993-enable-rpc-fe-config-testnet branch January 23, 2026 21:21
hypekostas pushed a commit that referenced this pull request Jul 6, 2026
## Bumps the all-actions group with 2 updates

- [docker/login-action](https://github.com/docker/login-action)
- [docker/build-push-action](https://github.com/docker/build-push-action)

---

## docker/login-action: 4.2.0 → 4.4.0

### Release notes (v4.4.0)

- Skip empty `registry-auth` secret mask by @crazy-max in #1035
- Bump `@aws-sdk/client-ecr` and `@aws-sdk/client-ecr-public` to 3.1077.0 in #1034

**Full Changelog:**  
docker/login-action@v4.3.0...v4.4.0

---

### Release notes (v4.3.0)

- Preserve names in esbuild bundle by @crazy-max in #1022
- Bump `@aws-sdk/client-ecr` and `@aws-sdk/client-ecr-public` to 3.1076.0 in #999 and #1030
- Bump `@docker/actions-toolkit` from 0.90.0 to 0.92.0 in #1004 and #1027
- Bump `@sigstore/core` from 3.1.0 to 3.2.1 in #1023
- Bump `@sigstore/verify` from 3.1.0 to 3.1.1 in #1029
- Bump http-proxy-agent and https-proxy-agent to 9.1.0 in #1017
- Bump js-yaml from 4.1.1 to 5.2.0 in #1028
- Bump sigstore from 4.1.0 to 4.1.1 in #1031
- Bump tmp from 0.2.5 to 0.2.7 in #1002
- Bump undici from 6.24.1 to 6.27.0 in #1020
- Bump vite from 7.3.3 to 7.3.6 in #1019

**Full Changelog:**  
docker/login-action@v4.2.0...v4.3.0

---

## docker/build-push-action: 7.2.0 → 7.3.0

### Release notes (v7.3.0)

- Preserve names in esbuild bundle by @crazy-max in #1567
- Bump `@docker/actions-toolkit` from 0.90.0 to 0.92.0 in #1545 and #1572
- Bump `@sigstore/core` from 3.1.0 to 3.2.1 in #1568
- Bump js-yaml from 4.1.1 to 4.3.0 in #1566
- Bump tmp from 0.2.5 to 0.2.7 in #1547
- Bump undici from 6.24.1 to 6.27.0 in #1564
- Bump vite from 7.3.2 to 7.3.6 in #1563

**Full Changelog:**  
docker/build-push-action@v7.2.0...v7.3.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants