Skip to content

Add stellar container use to set the default engine - #2647

Merged
fnando merged 1 commit into
mainfrom
container-use
Jul 16, 2026
Merged

Add stellar container use to set the default engine#2647
fnando merged 1 commit into
mainfrom
container-use

Conversation

@fnando

@fnando fnando commented Jul 16, 2026

Copy link
Copy Markdown
Member

What

Adds two subcommands for managing a persistent default container engine:

  • stellar container use <engine> — writes the chosen engine (docker or apple-container) to the global config.toml under defaults.container_engine.
  • stellar container unset — removes that persisted default.

On startup the persisted default is loaded into STELLAR_CONTAINER_ENGINE via set_env_from_config, so it feeds the existing engine resolution without a new code path. An explicit --engine flag or an already-set STELLAR_CONTAINER_ENGINE still takes precedence, and container use warns when the env var is set since it would override the value being saved.

Config plumbing: a container_engine field on Defaults, set_container_engine/unset_container_engine on Config, and write_default_container_engine/unset_default_container_engine on the locator.

Why

Builds on the --engine flag (base branch) so users no longer have to pass --engine on every stellar container invocation. Setting the engine once persists it across commands, matching how other stellar defaults (network, identity) already work.

Known limitations

N/A

@github-project-automation github-project-automation Bot moved this to Backlog (Not Ready) in DevX Jul 16, 2026
@fnando
fnando requested review from leighmcculloch and mootz12 July 16, 2026 15:12
Base automatically changed from container-engine-selection to main July 16, 2026 15:14
@fnando
fnando enabled auto-merge (squash) July 16, 2026 15:24
@fnando fnando self-assigned this Jul 16, 2026
@fnando fnando moved this from Backlog (Not Ready) to Needs Review in DevX Jul 16, 2026
@fnando
fnando merged commit 90a2ffb into main Jul 16, 2026
229 of 230 checks passed
@fnando
fnando deleted the container-use branch July 16, 2026 22:18
@github-project-automation github-project-automation Bot moved this from Needs Review to Done in DevX Jul 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants