Move Docker image distribution to its own repo - #2616
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes Docker image build/publish assets from stellar/stellar-cli and updates user-facing documentation to point to the dedicated Docker distribution repository (stellar/stellar-cli-docker) and Docker Hub.
Changes:
- Added a Docker run snippet and pointers to the new Docker distribution repo + Docker Hub in the main README.
- Removed the legacy Docker build recipe and entrypoint script from this repository.
- Deleted the GitHub Actions workflow that built/published Docker images and updated the Docker Hub description.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
README.md |
Documents how to run the CLI via Docker and links users to the new source-of-truth repo and Docker Hub. |
entrypoint.sh |
Removes the Docker entrypoint script now owned by the separate Docker distribution repo. |
Dockerfile |
Removes the Docker image build recipe from this repo to prevent drift with the new distribution repo. |
docker/README.md |
Removes the Docker Hub description content that was previously maintained here. |
.github/workflows/docker.yml |
Removes the Docker image build/publish workflow now handled elsewhere. |
70ca28b to
093b09c
Compare
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7c36466f45
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
What
Removes the
Dockerfile, itsentrypoint.sh, thedocker/README.md(Docker Hub description), and thedocker.ymlworkflow that built and published CLI images. Adds a note to the README's Install section pointing users to the dedicated stellar/stellar-cli-docker repository and Docker Hub.Why
Docker image building and distribution is now owned by the
stellar/stellar-cli-dockerrepository, so keeping the Dockerfile and publishing workflow here is redundant and risks the two drifting apart. Centralizing it in one place keeps the source of truth clear.Known limitations
N/A — the
ledger-emulator.ymlworkflow and thestellar containercommand still use Docker as a runtime and are unaffected; only image publishing was removed.