Make ledger device errors more informative - #2336
Merged
Merged
Conversation
elizabethengelman
marked this pull request as ready for review
December 19, 2025 00:12
elizabethengelman
force-pushed
the
fix/update-ledger-errors
branch
2 times, most recently
from
December 19, 2025 14:30
f87e44b to
fbbda9f
Compare
elizabethengelman
force-pushed
the
fix/update-ledger-errors
branch
from
December 19, 2025 14:41
fbbda9f to
4c2bfef
Compare
fnando
approved these changes
Dec 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
closes #1881
Why
We were handling all of the ledger error codes with the same error message, and it was difficult to troubleshoot common issues. Hopefully this will make it a bit clearer how to fix a failure when things go wrong.
Known limitations
n/a