Chore/bollard upgrade - #2330
Merged
Merged
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
elizabethengelman
force-pushed
the
chore/bollard-upgrade
branch
from
December 15, 2025 19:45
e6a3b64 to
ed34665
Compare
elizabethengelman
marked this pull request as ready for review
December 15, 2025 20:58
fnando
approved these changes
Dec 15, 2025
Contributor
Author
|
@fnando it looks like there is a failure in the rpc-tests that several PRs have as well. I think this is probably safe to merge with that failure, what do you think? |
Member
|
Yes, let's merge this. I'll take a look at the failing tests. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Upgrades
bollardandtestcontainersdependencies.Why
These two dependencies were pretty out of date because they previously had a dependency mismatch with their version of
bollard-stubs. As of the most recent version oftestcontainersdoesn't includebollard-stubsdirectly in its dependency list, so this mismatch shouldn't be a problem going forward.Known limitations
bollardhas an update that's merged into main, but not released yet that should take care of the failing cargo deny advisory check. fussybeaver/bollard#613