Pass 'quiet' value through to config.sign - #2300
Merged
Merged
Conversation
elizabethengelman
marked this pull request as ready for review
November 20, 2025 21:51
fnando
approved these changes
Dec 1, 2025
fnando
left a comment
fnando
left a comment
Member
There was a problem hiding this comment.
it's crazy how much had to be changed to pass down the prop. 🫠
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
closes #1840
Changes the
config.signsignature to also accept a boolean "quiet" value.Why
So we can pass that value through to
sign_with.sign_tx_envand respect thequietconfig when printing.Known limitations
n/a