Skip to content

upgrade typescript to latest version - #1641

Merged
willemneal merged 8 commits into
stellar:mainfrom
Benjtalkshow:upgrade-typescript
Nov 7, 2024
Merged

upgrade typescript to latest version#1641
willemneal merged 8 commits into
stellar:mainfrom
Benjtalkshow:upgrade-typescript

Conversation

@Benjtalkshow

@Benjtalkshow Benjtalkshow commented Oct 1, 2024

Copy link
Copy Markdown
Contributor

closes #1155

Upgrade TypeScript to Latest Version

  • Upgraded TypeScript to the latest stable version and updated tsconfig.json as needed.
  • Refactored code to resolve any type errors introduced by the upgrade.
  • Ran test and manual tests to ensure stability.

@Benjtalkshow
Benjtalkshow marked this pull request as draft October 1, 2024 22:21
@socket-security

socket-security Bot commented Oct 1, 2024

Copy link
Copy Markdown

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@types/[email protected] None +1 2.34 MB types
npm/[email protected] None 0 22.4 MB typescript-bot
npm/[email protected] None 0 22.4 MB typescript-bot

🚮 Removed packages: npm/[email protected]

View full report↗︎

@Benjtalkshow
Benjtalkshow marked this pull request as ready for review October 3, 2024 23:22
@Benjtalkshow

Copy link
Copy Markdown
Contributor Author

@willemneal can you check my PR?

@willemneal
willemneal requested a review from chadoh October 4, 2024 16:13

@willemneal willemneal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'll let @chadoh also approve since he is more familiar

@Benjtalkshow

Copy link
Copy Markdown
Contributor Author

LGTM! I'll let @chadoh also approve since he is more familiar

Alright

@Benjtalkshow

Copy link
Copy Markdown
Contributor Author

@willemneal
When are they going to merge this PR?

@chadoh chadoh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good

@leighmcculloch

Copy link
Copy Markdown
Member

@chadoh @willemneal Is this okay to be merged?

@chadoh chadoh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@willemneal
willemneal enabled auto-merge (squash) November 6, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

TS Bindings: Upgrade Typescript to latest

5 participants