Skip to content

feat(ts-bindings): upgrade stellar-sdk to 12.2.0 - #1606

Merged
willemneal merged 1 commit into
mainfrom
feat/ts-bindings/stellar-sdk-12.2.0
Nov 7, 2024
Merged

feat(ts-bindings): upgrade stellar-sdk to 12.2.0#1606
willemneal merged 1 commit into
mainfrom
feat/ts-bindings/stellar-sdk-12.2.0

Conversation

@chadoh

@chadoh chadoh commented Sep 16, 2024

Copy link
Copy Markdown
Contributor

What

Upgrade the version of stellar-sdk-js used by TS Bindings-generated libraries

Why

This is the latest version

Known limitations

[TODO or N/A]

@socket-security

socket-security Bot commented Sep 16, 2024

Copy link
Copy Markdown

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@stellar/[email protected] Transitive: environment, filesystem, network +25 45.8 MB stellar-npm-ci

🚮 Removed packages: npm/@stellar/[email protected], npm/@stellar/[email protected], npm/@types/[email protected], npm/[email protected]

View full report↗︎

Comment thread cmd/crates/soroban-spec-typescript/src/project_template/package.json Outdated
@chadoh
chadoh requested a review from Shaptic September 18, 2024 15:03

@Shaptic Shaptic left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was a make command that modified a bunch of generated files in the past; I see a smaller diff than I used do, so I'm just making sure that's not a thing anymore. Otherwise LGTM! 👍

@leighmcculloch

Copy link
Copy Markdown
Member

@chadoh Is this good to merge?

@chadoh
chadoh force-pushed the feat/ts-bindings/stellar-sdk-12.2.0 branch from 4758f2a to 5027549 Compare November 6, 2024 22:25
@chadoh

chadoh commented Nov 6, 2024

Copy link
Copy Markdown
Contributor Author

Re-ran make build-snapshot to make sure and one other file ended up in the checked-in build-artifact folder. It's ready now!

@willemneal
willemneal enabled auto-merge (squash) November 6, 2024 22:44
@fnando

fnando commented Nov 7, 2024

Copy link
Copy Markdown
Member

@chadoh this needs to be rebased, due to #1155 being merged.

@chadoh
chadoh force-pushed the feat/ts-bindings/stellar-sdk-12.2.0 branch from 35f3539 to 7ecadca Compare November 7, 2024 19:17
@willemneal
willemneal merged commit 11e08ef into main Nov 7, 2024
@willemneal
willemneal deleted the feat/ts-bindings/stellar-sdk-12.2.0 branch November 7, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants