feat: tx send - #1592
Merged
Merged
Conversation
The new `sign` subcommand allows for signing a passed transaction envelope. And can choose a different source_account than the signing key's corresponding public key.
Additionally, `signer::{Transaction, TransactionHash, Blob}` traits which simplifies the interface. Using blanket implementations, any type that implements `Blob`, will implement, `TransactionHash` and any type that implements `TransactionHash` implements `Transaction`, which uses the hash. This will allow for types to opt in to how they want to sign the transaction.
Co-authored-by: Leigh McCulloch <[email protected]>
Remove Blob trait. Add to TransactionHash trait to include hint. Move print to top level signer and fix test. Also remove the prompt for this PR since the sign command is already approval for signing.
5 tasks
Add tx send subcommand to send transaction to the network
willemneal
force-pushed
the
feat/tx_send
branch
from
September 23, 2024 19:22
e951427 to
e33f097
Compare
Contributor
Author
|
@leighmcculloch This is ready when the |
leighmcculloch
approved these changes
Sep 24, 2024
leighmcculloch
left a comment
leighmcculloch
left a comment
Member
There was a problem hiding this comment.
I merged main in and resolved conflicts, and updated a test.
Lgtm.
leighmcculloch
enabled auto-merge (squash)
September 24, 2024 04:39
elizabethengelman
pushed a commit
that referenced
this pull request
Sep 24, 2024
Co-authored-by: Leigh McCulloch <[email protected]>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add tx send subcommand to send transaction to the network