Update getEvents to take topics as &[TopicFilter] instead of &[String] - #57
Merged
Conversation
The rpc endpoint expects the topics to be passed an array of topic filters - which are arrays of segment filters instead of arrays of the topic string directly https://developers.stellar.org/docs/data/apis/rpc/api-reference/methods/getEvents
elizabethengelman
marked this pull request as ready for review
November 19, 2025 15:02
mootz12
approved these changes
Nov 19, 2025
elizabethengelman
added a commit
to stellar/stellar-cli
that referenced
this pull request
Nov 24, 2025
…2292) ### What closes #2021 related rpc-client pr: stellar/rs-stellar-rpc-client#57 Updates the topic filter structure that is being passed to the rpc server `getEvents` method, to align with it's expected API. The GetEventsRequest, from the rpc server, is expecting the topics to be an array of TopicFilters, and a TopicFilter is an array of SegmentFilters. So it is expecting an array of arrays. ### Why We are currently just passing in a segment filter, without nesting it in an array of arrays, and are seeing an error when doing so.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rpc endpoint expects the topics to be passed an array of topic filters - which are arrays of segment filters instead of arrays of the topic string directly
https://developers.stellar.org/docs/data/apis/rpc/api-reference/methods/getEvents
What
closes stellar/stellar-cli#2021
related CLI pr: stellar/stellar-cli#2292
Why
to support the cli pr: stellar/stellar-cli#2292
Known limitations
n/a