Event bindings review fixes - #1565
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates event handling and generated bindings for safer parsing, collision-free names, and encode-side filter types.
Changes:
- Makes
findEventreturnundefinedand narrows event exports. - Hardens parsed event objects and binding generation.
- Improves tests, documentation, snapshots, and SAC rerun handling.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/contract/spec.ts |
Updates the public findEvent API. |
src/contract/event_spec.ts |
Adds safe lookup and null-prototype event data. |
src/contract/index.ts |
Exports only the event result type. |
src/bindings/types.ts |
Disambiguates generated event interfaces. |
src/bindings/client.ts |
Disambiguates filters and uses input types. |
test/unit/spec/event_spec.test.ts |
Tests lookup and prototype safety. |
test/unit/bindings/collisions.test.ts |
Tests generated-name collisions. |
test/e2e/src/non-sim-sac-transfer.test.ts |
Tolerates an existing native SAC. |
test/e2e/src/__snapshots__/bindings.test.ts.snap |
Updates generated filter signatures. |
docs/reference/contracts-client.md |
Documents the breaking API change. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| return this.eventInterfaceNames; | ||
| } | ||
|
|
||
| const reserved = new Set<string>(); |
quietbits
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
findEventnow returnsundefinedfor an unmatched event instead of throwing.constructorcan't collide withObject.prototype.event_specbarrel now exports onlyParsedEvent.