protocols/rpc: Add LedgerCloseTime to GetHealthResponse by felixl256 · Pull Request #5958 · stellar/go-stellar-sdk

felixl256 · 2026-06-19T05:08:12Z

PR Checklist

PR Structure

This PR has reasonably narrow scope (if not, break it down into smaller PRs).
This PR avoids mixing refactoring changes with feature changes (split into two PRs otherwise).
This PR's title starts with name of package that is most changed in the PR, ex. services/friendbot, or all or doc if the changes are broad or impact many packages.

Thoroughness

This PR adds tests for the most critical parts of the new functionality or fixes. (N/A — this is a data-only struct field; behavior is exercised in stellar/stellar-rpc.)
I've updated any docs affected by this change (godoc on the new field).

Release planning

I've reviewed the changes in this PR and updated the relevant CHANGELOG.md.
I've decided this is a non-breaking, additive change (minor), targeted at main.

What

Adds a LatestLedgerCloseTime field (unix timestamp, in seconds) to protocols/rpc.GetHealthResponse.

Why

The RPC getHealth method already returns latestLedger, but not the time at which that ledger closed. Consumers that want to assess ledger freshness from the lightweight health endpoint currently have to additionally call getLatestLedger, which always returns the full headerXdr + metadataXdr of the ledger (multiple MB on active ledgers) — far too heavy for a health/monitoring probe.

The close time is the natural companion to latestLedger. Naming and format mirror the existing top-level latestLedgerCloseTime field already present in GetLedgersResponse (plain int64 unix seconds).

Server-side population is added in a follow-up PR in stellar/stellar-rpc.

Known limitations

N/A — additive, backward-compatible field (existing clients ignore the new field).

felixl256 · 2026-06-19T05:09:27Z

Server-side consumer (populates the field on the getHealth handler): stellar/stellar-rpc#797

Copilot

Pull request overview

Adds an additional timestamp field to the RPC protocol type for getHealth, allowing consumers to determine ledger freshness without calling heavier endpoints.

Changes:

Extend protocols/rpc.GetHealthResponse with LatestLedgerCloseTime (unix seconds) and add godoc.
Add a Pending changelog entry describing the new response field.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
protocols/rpc/get_health.go	Adds `LatestLedgerCloseTime` to the `getHealth` response struct.
CHANGELOG.md	Documents the new `GetHealthResponse` field under Pending features.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

felixl256 · 2026-06-19T05:12:45Z

Tracking issue: stellar/stellar-rpc#798

Expose the latest ledger's close time (unix seconds) on the getHealth response. The value is already available to the RPC server; surfacing it lets clients assess ledger freshness from the lightweight health endpoint without fetching full ledger metadata via getLatestLedger.

The getHealth handler depends on LatestLedgerCloseTime, added in stellar/go-stellar-sdk#5958 (not yet released). Point the module at the fork commit so this builds; remove this replace and bump to the released SDK version before merging.

Shaptic

One blocking comment below ⬇️ otherwise a welcome addition!

…e to GetHealthResponse String-encode `LatestLedgerCloseTime` with `,string` for JavaScript 64-bit compatibility, matching the other RPC close-time fields. Add `OldestLedgerCloseTime` (unix seconds, also string-encoded) for parity with `OldestLedger`; the stellar-rpc getHealth handler populates it from the already-available oldest ledger close time. Update CHANGELOG and the rpcclient GetHealth round-trip test.

chatgpt-codex-connector · 2026-06-23T07:38:59Z

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

Shaptic

Awesome!

Drop the temporary fork replace (added in d3715bc) now that the getHealth close-time fields have merged upstream (stellar/go-stellar-sdk#5958). No tagged SDK release includes them yet, so require the post-merge main pseudo-version for now; bump to a tagged release once one is published.

Pulls in stellar/go-stellar-sdk#5958. fc9acb3f is the current SDK main tip; no tagged release includes it yet.

Conflicts: CHANGELOG.md (kept both — main's Pending entry for #5958 plus the 0.7.0 section and backfill), xdr/xdr_views_generated.go (regenerated with main's extended generator (#5951) over the P28 XDR; build and xdr/ingest tests pass). Train: #5967 Co-Authored-By: Claude Fable 5 <[email protected]>

@karthikiyer56

… updates (#1185) Yes — the previous response still rendered the Markdown. You want the **literal Markdown source**, with no HTML tags at all. ```markdown Bumps the minor-and-patch group with 7 updates in the `/` directory: | Package | From | To | | --- | --- | --- | | [github.com/aws/aws-sdk-go-v2](https://github.com/aws/aws-sdk-go-v2) | `1.43.0` | `1.43.5` | | [github.com/aws/aws-sdk-go-v2/config](https://github.com/aws/aws-sdk-go-v2) | `1.32.31` | `1.32.36` | | [github.com/aws/aws-sdk-go-v2/service/ses](https://github.com/aws/aws-sdk-go-v2) | `1.37.0` | `1.37.5` | | [github.com/aws/aws-sdk-go-v2/service/sns](https://github.com/aws/aws-sdk-go-v2) | `1.42.0` | `1.42.5` | | [github.com/stellar/go-stellar-sdk](https://github.com/stellar/go-stellar-sdk) | `0.6.0` | `0.7.2` | | [golang.org/x/crypto](https://github.com/golang/crypto) | `0.54.0` | `0.55.0` | | [golang.org/x/net](https://github.com/golang/net) | `0.57.0` | `0.58.0` | Updates `github.com/aws/aws-sdk-go-v2` from 1.43.0 to 1.43.5 ### Commits - [`a14f5f1`](aws/aws-sdk-go-v2@a14f5f1) Release 2026-08-10 - [`339f0b6`](aws/aws-sdk-go-v2@339f0b6) Regenerated Clients - [`0978e3d`](aws/aws-sdk-go-v2@0978e3d) Update API model - [`3cc614d`](aws/aws-sdk-go-v2@3cc614d) Fix codegen mp ([#3508](https://redirect.github.com/aws/aws-sdk-go-v2/issues/3508)) - [`1434b18`](aws/aws-sdk-go-v2@1434b18) generate response snapshots for json ([#3507](https://redirect.github.com/aws/aws-sdk-go-v2/issues/3507)) - [`ad58f77`](aws/aws-sdk-go-v2@ad58f77) Checkout smithy-go on PRs at the commit pointed out by SMITHY_GO_CODEGEN_VERS... - [`c002860`](aws/aws-sdk-go-v2@c002860) feat: move close-body, logger, and service-metadata work out of the middlewar... - [`f152336`](aws/aws-sdk-go-v2@f152336) Release 2026-08-07 - [`37d88d7`](aws/aws-sdk-go-v2@37d88d7) Regenerated Clients - [`c54b278`](aws/aws-sdk-go-v2@c54b278) Update endpoints model - Additional commits viewable in [compare view](aws/aws-sdk-go-v2@v1.43.0...v1.43.5) Updates `github.com/aws/aws-sdk-go-v2/config` from 1.32.31 to 1.32.36 ### Commits - [`a14f5f1`](aws/aws-sdk-go-v2@a14f5f1) Release 2026-08-10 - [`339f0b6`](aws/aws-sdk-go-v2@339f0b6) Regenerated Clients - [`0978e3d`](aws/aws-sdk-go-v2@0978e3d) Update API model - [`3cc614d`](aws/aws-sdk-go-v2@3cc614d) Fix codegen mp ([#3508](https://redirect.github.com/aws/aws-sdk-go-v2/issues/3508)) - [`1434b18`](aws/aws-sdk-go-v2@1434b18) generate response snapshots for json ([#3507](https://redirect.github.com/aws/aws-sdk-go-v2/issues/3507)) - [`ad58f77`](aws/aws-sdk-go-v2@ad58f77) Checkout smithy-go on PRs at the commit pointed out by SMITHY_GO_CODEGEN_VERS... - [`c002860`](aws/aws-sdk-go-v2@c002860) feat: move close-body, logger, and service-metadata work out of the middlewar... - [`f152336`](aws/aws-sdk-go-v2@f152336) Release 2026-08-07 - [`37d88d7`](aws/aws-sdk-go-v2@37d88d7) Regenerated Clients - [`c54b278`](aws/aws-sdk-go-v2@c54b278) Update endpoints model - Additional commits viewable in [compare view](aws/aws-sdk-go-v2@config/v1.32.31...config/v1.32.36) Updates `github.com/aws/aws-sdk-go-v2/credentials` from 1.19.30 to 1.19.35 ### Commits - [`a14f5f1`](aws/aws-sdk-go-v2@a14f5f1) Release 2026-08-10 - [`339f0b6`](aws/aws-sdk-go-v2@339f0b6) Regenerated Clients - [`0978e3d`](aws/aws-sdk-go-v2@0978e3d) Update API model - [`3cc614d`](aws/aws-sdk-go-v2@3cc614d) Fix codegen mp ([#3508](https://redirect.github.com/aws/aws-sdk-go-v2/issues/3508)) - [`1434b18`](aws/aws-sdk-go-v2@1434b18) generate response snapshots for json ([#3507](https://redirect.github.com/aws/aws-sdk-go-v2/issues/3507)) - [`ad58f77`](aws/aws-sdk-go-v2@ad58f77) Checkout smithy-go on PRs at the commit pointed out by SMITHY_GO_CODEGEN_VERS... - [`c002860`](aws/aws-sdk-go-v2@c002860) feat: move close-body, logger, and service-metadata work out of the middlewar... - [`f152336`](aws/aws-sdk-go-v2@f152336) Release 2026-08-07 - [`37d88d7`](aws/aws-sdk-go-v2@37d88d7) Regenerated Clients - [`c54b278`](aws/aws-sdk-go-v2@c54b278) Update endpoints model - Additional commits viewable in [compare view](aws/aws-sdk-go-v2@credentials/v1.19.30...credentials/v1.19.35) Updates `github.com/aws/aws-sdk-go-v2/service/ses` from 1.37.0 to 1.37.5 ### Commits - [`b4784c1`](aws/aws-sdk-go-v2@b4784c1) Release 2026-07-01 - [`97c0201`](aws/aws-sdk-go-v2@97c0201) Regenerated Clients - [`6687238`](aws/aws-sdk-go-v2@6687238) Update endpoints model - [`995297f`](aws/aws-sdk-go-v2@995297f) Update API model - [`c26cfc6`](aws/aws-sdk-go-v2@c26cfc6) Fix bump smithy-go to cover multiple issues ([#3461](https://redirect.github.com/aws/aws-sdk-go-v2/issues/3461)) - [`fae66b8`](aws/aws-sdk-go-v2@fae66b8) Set transfer manager error as the first error seen, preventing race condition... - [`cf0eabd`](aws/aws-sdk-go-v2@cf0eabd) Release 2026-06-30 - [`ad0c091`](aws/aws-sdk-go-v2@ad0c091) Regenerated Clients - [`196e961`](aws/aws-sdk-go-v2@196e961) Update endpoints model - [`1529ead`](aws/aws-sdk-go-v2@1529ead) Update API model - Additional commits viewable in [compare view](aws/aws-sdk-go-v2@v1.37.0...service/pi/v1.37.5) Updates `github.com/aws/aws-sdk-go-v2/service/sns` from 1.42.0 to 1.42.5 ### Commits - [`dcbed91`](aws/aws-sdk-go-v2@dcbed91) Release 2026-01-09 - [`08120e8`](aws/aws-sdk-go-v2@08120e8) Regenerated Clients - [`1d7a925`](aws/aws-sdk-go-v2@1d7a925) Update endpoints model - [`482067d`](aws/aws-sdk-go-v2@482067d) Update API model - [`4662404`](aws/aws-sdk-go-v2@4662404) remove example ([#3282](https://redirect.github.com/aws/aws-sdk-go-v2/issues/3282)) - [`c28a6f4`](aws/aws-sdk-go-v2@c28a6f4) Release 2026-01-07 - [`2fa7a72`](aws/aws-sdk-go-v2@2fa7a72) Regenerated Clients - [`077cbaa`](aws/aws-sdk-go-v2@077cbaa) Update endpoints model - [`3282dbc`](aws/aws-sdk-go-v2@3282dbc) Update API model - [`3daa74a`](aws/aws-sdk-go-v2@3daa74a) Release 2026-01-06 - Additional commits viewable in [compare view](aws/aws-sdk-go-v2@v1.42.0...service/amp/v1.42.5) Updates `github.com/stellar/go-stellar-sdk` from 0.6.0 to 0.7.2 ### Release Notes Source: [github.com/stellar/go-stellar-sdk releases](https://github.com/stellar/go-stellar-sdk/releases) #### v0.7.2 ##### What's Changed - xdr: compare assets by their XDR encoding, and use Equals for asset equality by [@karthikiyer56](https://github.com/karthikiyer56) in [stellar/go-stellar-sdk#5974](https://redirect.github.com/stellar/go-stellar-sdk/pull/5974) - txnbuild: consolidate liquidity pool ordering guards; xdr and ingest cleanups by [@karthikiyer56](https://github.com/karthikiyer56) in [stellar/go-stellar-sdk#5978](https://redirect.github.com/stellar/go-stellar-sdk/pull/5978) - strkey: enforce SEP-23 payload lengths in Decode and DecodeAny by [@karthikiyer56](https://github.com/karthikiyer56) in [stellar/go-stellar-sdk#5977](https://redirect.github.com/stellar/go-stellar-sdk/pull/5977) **Full Changelog:** [v0.7.1...v0.7.2](stellar/go-stellar-sdk@v0.7.1...v0.7.2) #### v0.7.1 ##### What's Changed - stellartoml: validate domain in GetStellarToml for parity with sibling by [@karthikiyer56](https://github.com/karthikiyer56) in [stellar/go-stellar-sdk#5970](https://redirect.github.com/stellar/go-stellar-sdk/pull/5970) - ingest: one ledger walk — ExtractLedgerTxParts + EventsFromTxParts/FeesFromTxParts (supersedes the extractor bundles) by [@karthikiyer56](https://github.com/karthikiyer56) in [stellar/go-stellar-sdk#5966](https://redirect.github.com/stellar/go-stellar-sdk/pull/5966) **Full Changelog:** [v0.7.0...v0.7.1](stellar/go-stellar-sdk@v0.7.0...v0.7.1) #### v0.7.0 ##### What's Changed - ingest,network,xdr: zero-copy XDR view extractors for full-history ingestion by [@chowbao](https://github.com/chowbao) in [stellar/go-stellar-sdk#5949](https://redirect.github.com/stellar/go-stellar-sdk/pull/5949) - xdr,xdrgen,ingest: extend xdr views (decoded discriminants, typed opaque, count validation, Fields) and rebuild the view extractors on them by [@tamirms](https://github.com/tamirms) in [stellar/go-stellar-sdk#5951](https://redirect.github.com/stellar/go-stellar-sdk/pull/5951) - protocols/rpc: add UseUpgradedAuth flag to SimulateTransactionRequest by [@Ryang-21](https://github.com/Ryang-21) in [stellar/go-stellar-sdk#5948](https://redirect.github.com/stellar/go-stellar-sdk/pull/5948) - protocols/rpc: Add LedgerCloseTime to GetHealthResponse by [@felixl256](https://github.com/felixl256) in [stellar/go-stellar-sdk#5958](https://redirect.github.com/stellar/go-stellar-sdk/pull/5958) - ingest/loadtest: expand loadtest functionality to handle multiple ledger bundles by [@cjonas9](https://github.com/cjonas9) in [stellar/go-stellar-sdk#5959](https://redirect.github.com/stellar/go-stellar-sdk/pull/5959) - ingest: expose fee-bump inner hashes on the view extractors by [@tamirms](https://github.com/tamirms) in [stellar/go-stellar-sdk#5964](https://redirect.github.com/stellar/go-stellar-sdk/pull/5964) - ingest/ledgerbackend: Update captive-core-pubnet.cfg: swap SP with Obsrvr by [@drebelsky](https://github.com/drebelsky) in [stellar/go-stellar-sdk#5963](https://redirect.github.com/stellar/go-stellar-sdk/pull/5963) - Protocol 28 (CAP-0085) by [@sisuresh](https://github.com/sisuresh) in [stellar/go-stellar-sdk#5965](https://redirect.github.com/stellar/go-stellar-sdk/pull/5965) ##### New Contributors - [@Ryang-21](https://github.com/Ryang-21) made their first contribution in [stellar/go-stellar-sdk#5948](https://redirect.github.com/stellar/go-stellar-sdk/pull/5948) - [@felixl256](https://github.com/felixl256) made their first contribution in [stellar/go-stellar-sdk#5958](https://redirect.github.com/stellar/go-stellar-sdk/pull/5958) **Full Changelog:** [v0.6.0...v0.7.0](stellar/go-stellar-sdk@v0.6.0...v0.7.0) #### v0.6.1 ##### What's Changed - Backports for Horizon 27.0.1 (release-0.6.1) by [@karthikiyer56](https://github.com/karthikiyer56) in [stellar/go-stellar-sdk#5979](https://redirect.github.com/stellar/go-stellar-sdk/pull/5979) **Full Changelog:** [v0.6.0...v0.6.1](stellar/go-stellar-sdk@v0.6.0...v0.6.1) ### Changelog Source: [github.com/stellar/go-stellar-sdk changelog](https://github.com/stellar/go-stellar-sdk/blob/main/CHANGELOG.md) # Changelog This repository adheres to [Go module Versioning](https://go.dev/doc/modules/version-numbers). This monorepo contains a number of SDKs: - `horizonclient` ([changelog](https://github.com/stellar/go-stellar-sdk/blob/main/clients/horizonclient/CHANGELOG.md)) - `txnbuild` ([changelog](https://github.com/stellar/go-stellar-sdk/blob/main/txnbuild/CHANGELOG.md)) - `rpcclient` ([changelog](https://github.com/stellar/go-stellar-sdk/blob/main/clients/rpcclient/CHANGELOG.md)) - `corelient` ([changelog](https://github.com/stellar/go-stellar-sdk/blob/main/clients/stellarcore/CHANGELOG.md)) Official project releases may be found here: [https://github.com/stellar/go-stellar-sdk/releases](https://github.com/stellar/go-stellar-sdk/releases) ## Pending ### New Features - protocols/rpc: Add `LatestLedgerCloseTime` and `OldestLedgerCloseTime` to `GetHealthResponse`, exposing the latest and oldest ledgers' close times (unix seconds) on the `getHealth` response ([#5958](https://redirect.github.com/stellar/go-stellar-sdk/pull/5958)) ### Breaking Changes - strkey: `Decode` and `DecodeAny` now validate the payload length against the version byte per [SEP-23](https://github.com/stellar/stellar-protocol/blob/master/ecosystem/sep-0023.md). Fixed-length keys (account ID, seed, muxed account, contract, liquidity pool, claimable balance, hashTx, hashX) must decode to their exact canonical size, and signed payloads must carry a declared payload length of 1–64 bytes matched by their zero padding. Inputs with a valid checksum but a wrong-length payload — previously accepted by `Decode`, `DecodeAny`, and every `IsValid*` helper — are now rejected ([#5977](https://redirect.github.com/stellar/go-stellar-sdk/pull/5977)). - `NewSignedPayload` rejects empty payloads, matching CAP-40 (the protocol fails such signers with `SET_OPTIONS_BAD_SIGNER`/`txMALFORMED`) and keeping `SignedPayload.Encode` output decodable. - Length re-checks that `Decode` now subsumes were removed from `xdr.AccountId.SetAddress`, `xdr.MuxedAccount.SetAddress`, `xdr.SignerKey.SetAddress`, `xdr.ClaimableBalanceId.DecodeFromStrkey`, `strkey.DecodeMuxedAccount`, `strkey.MuxedAccount.SetAccountID`, and txnbuild contract-address parsing. For wrong-length inputs, the xdr and txnbuild callers now return strkey's `invalid payload length` error instead of their own; the strkey muxed-account helpers keep their generic `invalid muxed account` / `invalid ed25519 public key` errors; `xdr.MuxedAccount.SetAddress` is unchanged (it rejects on encoded string length before decoding). - `keypair.ParseAddress` wraps every decode failure with `ErrInvalidKey`, so `errors.Is(err, ErrInvalidKey)` keeps matching wrong-length keys (and now also matches checksum/encoding failures, which previously returned the bare strkey error). - `DecodeSignedPayload` delegates structure validation to `Decode`; structurally invalid inputs now uniformly error with `invalid signed payload` (previously `signed payload too short: ...` or `invalid signed payload padding`). - xdr: `Asset.LessThan` now orders assets the way the protocol does — by the raw 32-byte issuer key — instead of by base32 strkey text, and `xdr.NewPoolId` requires strictly `a < b`, rejecting reversed and identical pairs ([#5974](https://redirect.github.com/stellar/go-stellar-sdk/pull/5974)) - txnbuild: liquidity pool operations reject asset pairs that are not strictly ordered; see the [txnbuild changelog](https://github.com/stellar/go-stellar-sdk/blob/main/txnbuild/CHANGELOG.md) ([#5974](https://redirect.github.com/stellar/go-stellar-sdk/pull/5974)) ### Bug Fixes - processors/token_transfer: trustline revocation now compares liquidity pool assets by value instead of pointer identity, fixing wrong-leg selection when burning pool shares ([#5974](https://redirect.github.com/stellar/go-stellar-sdk/pull/5974)) ## [0.7.0] ### New Features - xdr: Protocol 28 support (CAP-0083, CAP-0085). XDR regenerated from [stellar-xdr@9c9c1459](stellar/stellar-xdr@9c9c145), the commit stellar-core 28.0.0 pins; both CAPs are ungated upstream so `XDR_FEATURES` is now empty. ### Commits - [`b46a463`](stellar/go-stellar-sdk@b46a463) strkey: enforce SEP-23 payload lengths in Decode and DecodeAny ([#5977](https://redirect.github.com/stellar/go-stellar-sdk/issues/5977)) - [`f8cd5df`](stellar/go-stellar-sdk@f8cd5df) txnbuild: consolidate liquidity pool ordering guards; xdr and ingest cleanups... - [`d2f530f`](stellar/go-stellar-sdk@d2f530f) xdr: compare assets by their XDR encoding, and use Equals for asset equality ... - [`3114a80`](stellar/go-stellar-sdk@3114a80) ingest: one ledger walk — ExtractLedgerTxParts + EventsFromTxParts/FeesFromTx... - [`3c3872f`](stellar/go-stellar-sdk@3c3872f) stellartoml: validate domain in GetStellarToml for parity with sibling ([#5970](https://redirect.github.com/stellar/go-stellar-sdk/issues/5970)) - [`2b16db0`](stellar/go-stellar-sdk@2b16db0) Protocol 28 Support ([#5969](https://redirect.github.com/stellar/go-stellar-sdk/issues/5969)) - [`e5d0cb9`](stellar/go-stellar-sdk@e5d0cb9) Merge main into protocol-next ahead of the Protocol 28 GA merge - [`149b994`](stellar/go-stellar-sdk@149b994) Finalize Protocol 28: pin stellar-xdr @ `9c9c1459` ([#5968](https://redirect.github.com/stellar/go-stellar-sdk/issues/5968)) - [`82df764`](stellar/go-stellar-sdk@82df764) Protocol 28 (CAP-0085) XDR regeneration ([#5965](https://redirect.github.com/stellar/go-stellar-sdk/issues/5965)) - [`8dd9cad`](stellar/go-stellar-sdk@8dd9cad) Update captive-core-pubnet.cfg: swap SP with Obsrvr ([#5963](https://redirect.github.com/stellar/go-stellar-sdk/issues/5963)) - Additional commits viewable in [compare view](stellar/go-stellar-sdk@v0.6.0...v0.7.2) Updates `golang.org/x/crypto` from 0.54.0 to 0.55.0 ### Commits - [`f44d03d`](golang/crypto@f44d03d) go.mod: update golang.org/x dependencies - [`5ed4944`](golang/crypto@5ed4944) crypto/internal/poly1305: provide optimised assembly for riscv64 - [`b07833c`](golang/crypto@b07833c) ssh: return window credit for discarded extended data - [`d701c51`](golang/crypto@d701c51) acme: fix nil pointer dereference in pebble test error reporting - [`999d053`](golang/crypto@999d053) ssh: fix parsing of GSSAPI payloads offering multiple mechanisms - [`90f76b8`](golang/crypto@90f76b8) ssh: reject certificate signature keys before recursing - [`b53964a`](golang/crypto@b53964a) ssh: permit empty but non-nil HostKeyAlgorithms, KeyExchanges, Ciphers, MACs - [`626e40f`](golang/crypto@626e40f) ssh: drain stderr on forwarded TCP and Unix channels - [`31914c6`](golang/crypto@31914c6) x509roots/fallback: update bundle - [`f2135b8`](golang/crypto@f2135b8) all: clean up minor issues found by staticcheck - Additional commits viewable in [compare view](golang/crypto@v0.54.0...v0.55.0) Updates `golang.org/x/net` from 0.57.0 to 0.58.0 ### Commits - [`acc78e0`](golang/net@acc78e0) go.mod: update golang.org/x dependencies - [`90d10f0`](golang/net@90d10f0) internal/http3: delete invalid Content-Length if declared in server handler - [`08abf4d`](golang/net@08abf4d) internal/http3: infer headers when Content-Encoding is set but is empty - [`8d10596`](golang/net@8d10596) http2: avoid deadlocks in wrapped ClientConn state callback - [`99c3b0a`](golang/net@99c3b0a) http2/hpack: build the table lookup maps lazily, only for encoders - [`5a920b1`](golang/net@5a920b1) http3: rework registration to allow using a fake network - [`7fd2842`](golang/net@7fd2842) quic: return an error from Accept after PacketConn reader exits - [`825111d`](golang/net@825111d) quic: avoid busy-loop when keep-alive is blocked by congestion control - [`a02ddfa`](golang/net@a02ddfa) http/httpproxy: prioritize lowercase proxy environment variables - [`574e5eb`](golang/net@574e5eb) quic: halt conn goroutines on close when listener exits early - Additional commits viewable in [compare view](golang/net@v0.57.0...v0.58.0) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. --- You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore <dependency name> major version` will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself) - `@dependabot ignore <dependency name> minor version` will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself) - `@dependabot ignore <dependency name>` will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself) - `@dependabot unignore <dependency name>` will remove all of the ignore conditions of the specified dependency - `@dependabot unignore <dependency name> <ignore condition>` will remove all of the ignore conditions of the specified dependency ```

* changelog: cut the Pending section as 0.7.2, and record 0.7.1 v0.7.2 was tagged at b46a463 so that stellar-rpc, Horizon and Galexie v28.0.0 all pin a released SDK tag for Protocol 28; Horizon had been pinning a pseudo-version to get #5974. Everything the Pending section listed ships in it, with two corrections: * the `protocols/rpc` GetHealthResponse close-time fields (#5958) moved to [0.7.0] — that commit is an ancestor of the v0.7.0 tag, so it has been released since 2026-08-03. * added a [0.7.1] section for #5966 and #5970, which were tagged on 2026-08-04 without a changelog entry, so 0.7.2 does not absorb them. The ingest/ and txnbuild/ sub-changelogs still carry Pending sections whose contents span several released versions; untangling those is left alone here. * ingest: ApplyLedgerMetadata closes the datastore and ledger backend and propagates the PrepareRange error, so an early return no longer strands a goroutine per worker and a failed prepare no longer passes silently. * go.mod: the go-xdr bump to dc590f1, which fixes decoder bound handling for a variable-length field whose length prefix ends the input. 0.6.1 recorded this bump under Updates; 0.7.2 carries the same one. Co-authored-by: Claude Opus 5 (1M context) <[email protected]>

Copilot AI review requested due to automatic review settings June 19, 2026 05:08

felixl256 force-pushed the protocols-rpc-health-close-time branch from b0b0b72 to e090348 Compare June 19, 2026 05:08

Copilot started reviewing on behalf of felixl256 June 19, 2026 05:08 View session

felixl256 mentioned this pull request Jun 19, 2026

getHealth: return LedgerCloseTime in response stellar/stellar-rpc#797

Merged

Copilot AI reviewed Jun 19, 2026

View reviewed changes

Comment thread protocols/rpc/get_health.go Outdated

Comment thread CHANGELOG.md Outdated

felixl256 mentioned this pull request Jun 19, 2026

getHealth: expose latest and oldest ledger close times stellar/stellar-rpc#798

Closed

felixl256 force-pushed the protocols-rpc-health-close-time branch from bf8dc71 to 8c1d885 Compare June 19, 2026 08:55

Shaptic reviewed Jun 22, 2026

View reviewed changes

Comment thread protocols/rpc/get_health.go Outdated

Shaptic reviewed Jun 22, 2026

View reviewed changes

Comment thread protocols/rpc/get_health.go

felixl256 changed the title ~~protocols/rpc: Add LatestLedgerCloseTime to GetHealthResponse~~ protocols/rpc: Add LedgerCloseTime to GetHealthResponse Jun 23, 2026

felixl256 requested a review from Shaptic June 23, 2026 08:13

Shaptic approved these changes Jun 24, 2026

View reviewed changes

Shaptic enabled auto-merge (squash) June 24, 2026 18:59

Shaptic merged commit fc9acb3 into stellar:main Jun 24, 2026
11 checks passed

felixl256 added a commit to felixl256/stellar-rpc that referenced this pull request Jun 25, 2026

chore: bump go-stellar-sdk to fc9acb3f for getHealth close-time fields

ac4d00a

Pulls in stellar/go-stellar-sdk#5958. fc9acb3f is the current SDK main tip; no tagged release includes it yet.

karthikiyer56 mentioned this pull request Aug 10, 2026

Backports for Horizon 27.0.1 (release-0.6.1) #5979

Merged

This was referenced Aug 14, 2026

changelog: cut the Pending section as 0.7.2, and record 0.7.1 #5980

Merged

Protocol 28 GA release train #5967

Closed

Navigation Menu

Uh oh!

protocols/rpc: Add LedgerCloseTime to GetHealthResponse - #5958

protocols/rpc: Add LedgerCloseTime to GetHealthResponse#5958
Shaptic merged 2 commits into
stellar:mainfrom
felixl256:protocols-rpc-health-close-time

felixl256 commented Jun 19, 2026

Uh oh!

felixl256 commented Jun 19, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

felixl256 commented Jun 19, 2026

Uh oh!

Uh oh!

Shaptic left a comment

Uh oh!

Uh oh!

chatgpt-codex-connector Bot commented Jun 23, 2026

Uh oh!

Shaptic left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

felixl256 commented Jun 19, 2026

PR Structure

Thoroughness

Release planning

What

Why

Known limitations

Uh oh!

felixl256 commented Jun 19, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

felixl256 commented Jun 19, 2026

Uh oh!

Uh oh!

Shaptic left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

chatgpt-codex-connector Bot commented Jun 23, 2026

Uh oh!

Shaptic left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants