Skip to content

Merge protocol-next (P26) back to main - #5930

Merged
urvisavla merged 3 commits into
mainfrom
protocol-next
Apr 1, 2026
Merged

Merge protocol-next (P26) back to main#5930
urvisavla merged 3 commits into
mainfrom
protocol-next

Conversation

@urvisavla

Copy link
Copy Markdown
Contributor
PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've reviewed the changes in this PR and if I consider them worthwhile for being mentioned on release notes then I have updated the relevant CHANGELOG.md within the component folder structure. For example, if I changed horizon, then I updated (services/horizon/CHANGELOG.md. I add a new line item describing the change and reference to this PR. If I don't update a CHANGELOG, I acknowledge this PR's change may not be mentioned in future release notes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Merge protocol-next (P26) back to main

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR merges Protocol 26 (“protocol-next”) updates back into main, primarily updating XDR definitions and their generated Go bindings to reflect new ledger/key-freezing related semantics and updated result codes.

Changes:

  • Update Stellar XDRs and regenerated Go bindings (new result codes; new config settings/types around frozen ledger keys and freeze bypass txs).
  • Bump tracked XDR commit/hash metadata used by generation (Makefile, xdr_commit_generated.txt, XdrFilesSHA256).
  • Adjust default Soroban resource instructions used by txnbuild.NewPaymentToContract.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
xdr/xdr_generated.go Regenerated XDR Go bindings: adds new result codes and new config-setting-related types/unions for frozen keys + bypass txs.
xdr/xdr_commit_generated.txt Updates the recorded XDR commit hash corresponding to regenerated artifacts.
xdr/Stellar-transaction.x Updates transaction-related XDR enums/unions to include new *_TRUSTLINE_FROZEN and txFROZEN_KEY_ACCESSED codes.
xdr/Stellar-contract-config-setting.x Adds EncodedLedgerKey and new config-setting structs/IDs for frozen keys and freeze-bypass tx sets/deltas.
txnbuild/invoke_host_function.go Increases the default Soroban instruction budget used for “payment to contract” operations.
Makefile Updates XDR_COMMIT to match the new generated XDR state.
gxdr/xdr_generated.go Regenerated gxdr bindings reflecting new result codes and config-setting additions.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread xdr/xdr_generated.go
Comment thread xdr/xdr_generated.go
Comment thread xdr/xdr_generated.go
Comment thread gxdr/xdr_generated.go
Comment thread xdr/Stellar-transaction.x
Comment thread xdr/Stellar-transaction.x
@urvisavla
urvisavla merged commit a445f0c into main Apr 1, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants