support/datastore: Fix ListFilePath for datastore bucket with no prefix - #5923
Merged
Conversation
… (only the bucket name)
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes ListFilePaths behavior for S3/GCS datastores when destination_bucket_path is just a bucket name (no configured prefix), ensuring object listing works correctly in that configuration.
Changes:
- Prevent appending a trailing
/when the datastore’s configured base prefix is empty (S3 + GCS). - Add coverage for the “no prefix” configuration in both S3 and GCS
ListFilePathstests.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| support/datastore/s3.go | Avoids converting an empty configured prefix into / during list operations. |
| support/datastore/gcs.go | Same fix as S3 for GCS object listing prefix handling. |
| support/datastore/s3_test.go | Adds a ListFilePaths regression test for bucket-only configuration (no prefix). |
| support/datastore/gcs_test.go | Adds the equivalent regression test for GCS (no prefix). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Shaptic
approved these changes
Mar 23, 2026
Shaptic
left a comment
Shaptic
left a comment
Contributor
There was a problem hiding this comment.
Confirmed that this fixes integration tests in RPC!
Shaptic
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot, orallordocif the changes are broad or impact manypackages.
Thoroughness
.mdfiles, etc... affected by this change). Take a look in the
docsfolder for a given service,like this one.
Release planning
CHANGELOG.mdwithin the component folder structure. For example, if I changed horizon, then I updated (services/horizon/CHANGELOG.md. I add a new line item describing the change and reference to this PR. If I don't update a CHANGELOG, I acknowledge this PR's change may not be mentioned in future release notes.semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
The fix corrects ListFilePath to handle datastore configurations where
destination_bucket_pathcontains only a bucket name with no prefix.Known limitations
N/A