Update XDR definitions for protocol-26 - #5919
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
tamirms
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Updates this repo’s Stellar XDR schema and regenerated Go bindings to match stellar/stellar-xdr@cff714a5, including newly introduced result codes and config-setting types.
Changes:
- Updated XDR source files (
Stellar-transaction.x,Stellar-contract-config-setting.x) to add new enum values and new config-setting structs/typedefs. - Regenerated Go XDR bindings in both
xdr/andgxdr/to reflect the updated schema. - Bumped the recorded upstream XDR commit in
xdr/xdr_commit_generated.txtandMakefile.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| xdr/xdr_generated.go | Regenerated canonical Go XDR types; adds new result codes and new config-setting arms/types (e.g., frozen ledger keys / bypass txs). |
| gxdr/xdr_generated.go | Regenerated “gxdr” bindings mirroring the schema updates (new enums/arms/types). |
| xdr/xdr_commit_generated.txt | Updates recorded upstream XDR commit hash to cff714a5…. |
| xdr/Stellar-transaction.x | Adds new transaction/liquidity/claim result codes (e.g., TRUSTLINE_FROZEN, FROZEN_KEY_ACCESSED). |
| xdr/Stellar-contract-config-setting.x | Adds EncodedLedgerKey typedef and new frozen/bypass config-setting structs and IDs. |
| Makefile | Updates XDR_COMMIT to cff714a5… for regeneration provenance. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
| } | ||
|
|
||
| // MustFrozenLedgerKeys retrieves the FrozenLedgerKeys value from the union, | ||
| // panicing if the value is not set. |
| } | ||
|
|
||
| // MustFrozenLedgerKeysDelta retrieves the FrozenLedgerKeysDelta value from the union, | ||
| // panicing if the value is not set. |
| } | ||
|
|
||
| // MustFreezeBypassTxs retrieves the FreezeBypassTxs value from the union, | ||
| // panicing if the value is not set. |
| } | ||
|
|
||
| // MustFreezeBypassTxsDelta retrieves the FreezeBypassTxsDelta value from the union, | ||
| // panicing if the value is not set. |
| LIQUIDITY_POOL_DEPOSIT_BAD_PRICE = -6, // deposit price outside bounds | ||
| LIQUIDITY_POOL_DEPOSIT_POOL_FULL = -7 // pool reserves are full | ||
| LIQUIDITY_POOL_DEPOSIT_POOL_FULL = -7, // pool reserves are full | ||
| LIQUIDITY_POOL_DEPOSIT_TRUSTLINE_FROZEN = -8 // trustline for one of the |
| // of the assets | ||
| LIQUIDITY_POOL_WITHDRAW_UNDER_MINIMUM = -5 // didn't withdraw enough | ||
| LIQUIDITY_POOL_WITHDRAW_UNDER_MINIMUM = -5, // didn't withdraw enough | ||
| LIQUIDITY_POOL_WITHDRAW_TRUSTLINE_FROZEN = -6 // trustline for one of the |
Shaptic
approved these changes
Mar 13, 2026
karthikiyer56
approved these changes
Mar 13, 2026
urvisavla
added a commit
that referenced
this pull request
Apr 1, 2026
* Update XDR definitions to cff714a5ebaaaf2dac343b3546c2df73f0b7a36e (#5919) * Bump default resource limits in NewPaymentToContract for protocol 26 (#5921) --------- Co-authored-by: tamirms <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cff714a5ebaaaf2dac343b3546c2df73f0b7a36ewhich has support for protocol-26🤖 Generated with Claude Code