services/horizon/internal/ingest: Add metrics for ingestion loaders - #5209
Merged
Conversation
aditya1702
reviewed
Feb 14, 2024
Contributor
|
since 2.28.3 went out last week unfortunately on a bit of rush, this needs to target master now |
sreuland
reviewed
Feb 21, 2024
sreuland
reviewed
Feb 21, 2024
sreuland
reviewed
Feb 21, 2024
sreuland
reviewed
Feb 21, 2024
Contributor
Author
|
@sreuland I think I have addressed all your feedback, could you take another look? |
Contributor
looks good, and thanks for consideration on suggestions! do need to re-target this pr to merge to |
tamirms
force-pushed
the
loader-metrics
branch
from
February 21, 2024 20:14
3cf3dc9 to
0ed0e10
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot, orallordocif the changes are broad or impact manypackages.
Thoroughness
.mdfiles, etc... affected by this change). Take a look in the
docsfolder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
Close https://github.com/stellar/go/issues/5154
We do not have any metrics capturing how long it takes to run the ingestion loaders:
https://github.com/stellar/go/blob/release-horizon-v2.28.0/services/horizon/internal/ingest/group_processors.go#L101-L105
This commit adds prometheus metrics for the duration of each loader so we can determine how much of ingestion is spent in the loaders vs the processors. We also added prometheus metrics capturing how many records were queried and inserted during the execution of each loader.
Known limitations
[N/A]