Allow installing additional deb packages. - #69
Merged
leighmcculloch merged 2 commits intoSep 3, 2024
Merged
Conversation
chadoh
approved these changes
Jul 8, 2024
chadoh
left a comment
chadoh
left a comment
There was a problem hiding this comment.
I assume the variable is set in a UI or separate repo somewhere?
|
Ah, I see, stellar/stellar-cli#1434 |
leighmcculloch
approved these changes
Sep 3, 2024
| run: sudo apt-get update && sudo apt-get -y install ${{ inputs.additional-deb-packages }} | ||
| - uses: actions/checkout@v3 | ||
| - uses: stellar/actions/rust-cache@main | ||
| - run: rustup update |
Member
There was a problem hiding this comment.
@fnando I merged this PR, but I think it would also be fair to add --no-verify to the publish which will mean the crate won't be built and you shouldn't need any deps installed.
Adding --no-verify might normally be a bit weird, except that all rust repos also use the publish dry run job prior, so we already have a guard against publishing things that don't verify (build).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.